Re: [VOTE] 3.4.1 RC1

2023-05-23 Thread Luke Chen
Hi Mickael, Thanks for pointing this out. Yes, I forgot to update the LICENSE-binary file. I'll create another RC build to patch it. Thanks Chris and Greg for pointing out these 2 issues. I've backported into v3.4 branch. Will include them in next RC build. Thanks Fede and Josep for helping veri

Re: [VOTE] 3.4.1 RC1

2023-05-23 Thread Mickael Maison
Hi Luke, I've had to update the LICENSE-binary file when running the 3.5.0 release and I noticed the file also needs updates in 3.4. If I run the validation logic described in https://issues.apache.org/jira/browse/KAFKA-12622, I get the following: audience-annotations-0.13.0 is missing in license

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Greg Harris
Also I'll point it out here so that everyone is aware, but I don't think it necessarily warrants a new RC on it's own: This patch: https://github.com/apache/kafka/pull/13005 is present on trunk/3.5.0, but is not present in 3.4.0/3.4.1-RC1. It is not a regression strictly, since it was already a pr

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Greg Harris
Hi Luke, I performed a test upgrade of MM2 from 3.4.0 to 3.4.1-RC1, and verified that the new offset translation logic worked as intended. Steps I took to verify: - Downloaded 3.4.0_2.13 from the Kafka website - Formatted and started two 3.4.0 1-node clusters, and configured MM2 to mirror data an

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Josep Prat
Hi Luke, I can confirm the *org.apache.kafka.common.utils.UtilsTest.testToLogDateTimeFormat* consistent failure when not running on a system set on UTC-0 timezone. I verified: - Built from source with Java 11 and Scala 2.13 - Checked signatures and hashes - Check Javadoc and checked links to JDK

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Chris Egerton
Hi Luke, Thanks for running the release! Steps I took to verify: - Built from source with Java 11 - Checked signatures and checksums - Ran the quickstart with Java 11 in KRaft mode - Ran all unit tests - - The org.apache.kafka.common.utils.UtilsTest.testToLogDateTimeDormat test case failed consi

Re: [VOTE] 3.4.1 RC1

2023-05-22 Thread Federico Valeri
Hi Luke, - Source signature and checksum - Build from source with Java 17 and Scala 2.13 - Full unit and integration test suite - Java app with staging Maven artifacts +1 (non binding) Thanks Fede PS: Links still point to RC0, but I checked and RC1 artifacts are there, including Maven. The only

[VOTE] 3.4.1 RC1

2023-05-22 Thread Luke Chen
Hello Kafka users, developers and client-developers, This is the 2nd candidate for release of Apache Kafka 3.4.1. This is a bugfix release with several fixes since the release of 3.4.0. A few of the major issues include: - core KAFKA-14644 Proce