Re: [VOTE] KIP-112 - Handle disk failure for JBOD

Thanks to everyone who voted and provided feedback! This KIP is now adopted with 3 binding +1s (Jun, Joel, Becket) and 1 non-binding +1s (Radai) Dong On Thu, Apr 27, 2017 at 4:12 PM, Dong Lin wrote: > Thanks for the vote Jun! > > I think that statement is probably OK because it assumes that br

Re: [VOTE] KIP-112 - Handle disk failure for JBOD

Thanks for the vote Jun! I think that statement is probably OK because it assumes that broker has bad log directories. If all log directories are good, the replica should be created in one of the good log directories. It is clarified in the wiki that "Even if isNewReplica=false and replica is not

Re: [VOTE] KIP-112 - Handle disk failure for JBOD

Hi, Dong, Thanks for the proposal. +1. Just one minor comment. in "3. Broker bootstraps with bad log directories", when a broker receives a LeaderAndIsrRequest with isNewReplica=False but not found on any good log directory, if all log directories are good, it seems that we should create the repl

Re: [VOTE] KIP-112 - Handle disk failure for JBOD

Thanks for the vote! Discussed with Joel offline. I have updated the KIP to specify that controller will consider a replica to be offline if KafkaStorageException is specified for the replica in the LeaderAndIsrResponse. The other two improvements may be done in the future KIP. On Wed, Apr 26,

Re: [VOTE] KIP-112 - Handle disk failure for JBOD

+1 Discussed a few edits/improvements with Dong. - Rather than a blanket (Error != None) condition for detecting offline replicas you probably want a storage exception-specific error code. - Definitely in favor of improvement #7 and it shouldn’t be too hard to do. When bouncing with a log direct

Re: [VOTE] KIP-112 - Handle disk failure for JBOD

+1 Thanks for the KIP. Made a pass and had some minor change. On Mon, Apr 3, 2017 at 3:16 PM, radai wrote: > +1, LGTM > > On Mon, Apr 3, 2017 at 9:49 AM, Dong Lin wrote: > > > Hi all, > > > > It seems that there is no further concern with the KIP-112. We would like > > to start the voting proc

Re: [VOTE] KIP-112 - Handle disk failure for JBOD

+1, LGTM On Mon, Apr 3, 2017 at 9:49 AM, Dong Lin wrote: > Hi all, > > It seems that there is no further concern with the KIP-112. We would like > to start the voting process. The KIP can be found at > *https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 112%3A+Handle+disk+failure+for+JBOD

[VOTE] KIP-112 - Handle disk failure for JBOD

Hi all, It seems that there is no further concern with the KIP-112. We would like to start the voting process. The KIP can be found at *https://cwiki.apache.org/confluence/display/KAFKA/KIP-112%3A+Handle+disk+failure+for+JBOD