Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

Hi all, We're getting close to the final 0.11 release and we still haven't gotten the version retrieval API for AdminClient in, as described by KAFKA-5214. Let's put this off until the next release so that we have some time to let it soak before shipping. This will just mean that we will remove

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

Hi Colin, Thanks for the feedback. Regarding the behaviour for brokers older than 0.11.0, I had gone for the Javadoc note because it made it possible to avoid the inefficiency of getting all topics for users who have disabled auto topic creation. After some thought and discussion, I agree that

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

Oops, I just realized if we do a call with topics=*, we don't need to make a follow-up call. :) The question still holds, though: is it worth sacrificing some scalability when talking to older brokers, to get saner semantics? cheers, Colin On Mon, May 22, 2017, at 11:41, Colin McCabe wrote: >

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

I definitely agree that auto topic creation is unexpected and confusing (even with the JavaDoc note in the API). The proposed solution of adding a flag to MetadataRequest seems pretty simple and reasonable. +1. As you noted, though, we don't have a way to do this for the 0.10.x releases. It

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

Hi all, Feedback from people who tried the AdminClient is that auto topic creation during describe is unexpected and confusing. This is consistent with the reaction of most people when they learn that MetadataRequest can cause topics to be created. We had assumed that we'd tackle this issue for

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

With binding +1 votes from Gwen Shapira, Sriram Subramanian, and Grant Henke, and a non-binding vote from Dong Lin, the vote passes. There were no +0 or -1 votes. As mentioned earlier, the interface will be unstable at first and we will continue to evolve it. thanks, Colin McCabe On Wed, Mar

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

On Fri, Mar 17, 2017, at 10:50, Jun Rao wrote: > Hi, Colin, > > Thanks for the KIP. Looks good overall. A few comments below. > > 1. Sometimes we return > CompletableFuture> > and some other times we return > Map > , which doesn't

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

Hi, Colin, Thanks for the KIP. Looks good overall. A few comments below. 1. Sometimes we return CompletableFuture> and some other times we return Map , which doesn't seem consistent. Is that intentional? 2. We support batching in

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

Hi all, It seems like people agree with the basic direction of the proposal and the API, including the operations that are included, the async and batching support, and the mechanisms for extending it in the future. If there's no more votes, I'd like to close the vote and start progress on this.

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

+1 On Tue, Mar 14, 2017 at 8:50 AM, Grant Henke wrote: > +1 > > On Tue, Mar 14, 2017 at 2:44 AM, Sriram Subramanian > wrote: > > > +1 (binding) > > > > Nice work in driving this. > > > > On Mon, Mar 13, 2017 at 10:31 PM, Gwen Shapira

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

+1 On Tue, Mar 14, 2017 at 2:44 AM, Sriram Subramanian wrote: > +1 (binding) > > Nice work in driving this. > > On Mon, Mar 13, 2017 at 10:31 PM, Gwen Shapira wrote: > > > +1 (binding) > > > > I expressed few concerns in the discussion thread, but in

Re: [VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

+1 (binding) Nice work in driving this. On Mon, Mar 13, 2017 at 10:31 PM, Gwen Shapira wrote: > +1 (binding) > > I expressed few concerns in the discussion thread, but in general this is > super important to get done. > > On Fri, Mar 10, 2017 at 10:38 AM, Colin McCabe

[VOTE] KIP-117: Add a public AdminClient API for Kafka admin operations

Hi all, I'd like to start voting on KIP-117 (https://cwiki.apache.org/confluence/display/KAFKA/KIP-117%3A+Add+a+public+AdminClient+API+for+Kafka+admin+operations ). The discussion thread can be found here: https://www.mail-archive.com/dev@kafka.apache.org/msg65697.html best, Colin