Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

PM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect > > Hey Randall, > > It seemed a bit cleaner to me, but I'm not sure if whether there is any > advantage to keeping the interfaces decoupled. I'd probably suggest going

RE: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

] Sent: Tuesday, January 23, 2018 8:03 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect Hey Randall, It seemed a bit cleaner to me, but I'm not sure if whether there is any advantage to keeping the interfaces decoupled. I'd probably suggest going

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

Hey Randall, It seemed a bit cleaner to me, but I'm not sure if whether there is any advantage to keeping the interfaces decoupled. I'd probably suggest going for the simpler API unless you can think of a good reason not to. -Jason On Tue, Jan 23, 2018 at 8:47 AM, Randall Hauch

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

I mostly just followed the pattern of the Converter methods, which also take the individual components. Really, the only advantage of the current approach is that the HeaderConverter implementations are a bit more decoupled as they are not aware of the Header/Headers API nor the implementation

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

+1 (binding) Just one minor comment. It seems a little surprising that HeaderConverter does not use the Header interface. I expected something like this: Header toConnectHeader(String topic, String headerKey, byte[] value); byte[] fromConnectHeader(String topic, Header header); Was there a

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

+1 On Mon, Jan 22, 2018 at 2:48 PM, Gwen Shapira wrote: > +1 (binding) > > This is going to be HUGE! Thank you Randall. > > On Mon, Jan 22, 2018 at 1:18 PM Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Great addition! > > > > +1 (non-binding) > > > >

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

+1 (binding) This is going to be HUGE! Thank you Randall. On Mon, Jan 22, 2018 at 1:18 PM Konstantine Karantasis < konstant...@confluent.io> wrote: > Great addition! > > +1 (non-binding) > > Konstantine > > On Sun, Jan 21, 2018 at 7:26 PM, Ewen Cheslack-Postava > wrote: > >

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

Great addition! +1 (non-binding) Konstantine On Sun, Jan 21, 2018 at 7:26 PM, Ewen Cheslack-Postava wrote: > +1 (binding) > > Thanks for the work on this -- not a small upgrade to the Connect APIs! > > -Ewen > > On Fri, Jan 19, 2018 at 3:37 PM, Randall Hauch

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

+1 (binding) Thanks for the work on this -- not a small upgrade to the Connect APIs! -Ewen On Fri, Jan 19, 2018 at 3:37 PM, Randall Hauch wrote: > Hi everyone, > > I'd like to start the voting on this KIP to add support for headers in > Connect.: > >

[VOTE] KIP-145: Expose Record Headers in Kafka Connect

Hi everyone, I'd like to start the voting on this KIP to add support for headers in Connect.: *https://cwiki.apache.org/confluence/display/KAFKA/KIP-145+-+Expose+Record+Headers+in+Kafka+Connect *