Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 On Sat, Jun 24, 2017 at 4:37 AM, Matthias J. Sax wrote: > +1 > > On 6/23/17 9:43 PM, Guozhang Wang wrote: > > +1 > > > > On Fri, Jun 23, 2017 at 3:16 AM, Eno Thereska > > wrote: > > > >> +1 thanks! > >> > >> Eno > >>> On 23 Jun 2017, at 05:29,

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 On 6/23/17 9:43 PM, Guozhang Wang wrote: > +1 > > On Fri, Jun 23, 2017 at 3:16 AM, Eno Thereska > wrote: > >> +1 thanks! >> >> Eno >>> On 23 Jun 2017, at 05:29, James Chain wrote: >>> >>> Hi all, >>> >>> I apply original idea on

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 On Fri, Jun 23, 2017 at 3:16 AM, Eno Thereska wrote: > +1 thanks! > > Eno > > On 23 Jun 2017, at 05:29, James Chain wrote: > > > > Hi all, > > > > I apply original idea on KStream#writeAsText() and also update my pull > > request. > >

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 thanks! Eno > On 23 Jun 2017, at 05:29, James Chain wrote: > > Hi all, > > I apply original idea on KStream#writeAsText() and also update my pull > request. > Please re-review and re-cast the vote. > > James Chien

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

Hi all, I apply original idea on KStream#writeAsText() and also update my pull request. Please re-review and re-cast the vote. James Chien

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

Yes. Please update the wiki page of KIP-160 as well, and then recall the voting process. For those who already voted, please re-review the wiki page and re-cast your vote. Guozhang On Thu, Jun 15, 2017 at 7:08 PM, James Chain wrote: > @Guozhang > > OK, I will add it

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

@Guozhang OK, I will add it on writeAsText as well. Should I add writeAsText part in KIP-160 ? James Chien

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 On Thu, Jun 15, 2017 at 9:22 PM, Guozhang Wang wrote: > James, > > As I commented on the discussion thread, have you considered doing the same > for writeAsText as well? > > Guozhang > > On Thu, Jun 15, 2017 at 4:33 PM, Matthias J. Sax > wrote: > >

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

James, As I commented on the discussion thread, have you considered doing the same for writeAsText as well? Guozhang On Thu, Jun 15, 2017 at 4:33 PM, Matthias J. Sax wrote: > +1 > > Thanks for the KIP! > > > -Matthias > > On 6/14/17 6:59 PM, James Chain wrote: > > I had

Re: [VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

+1 Thanks for the KIP! -Matthias On 6/14/17 6:59 PM, James Chain wrote: > I had start a voting process for KIP-160 > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-160:+Augment+KStream.print()+to+allow+users+pass+in+extra+parameters+in+the+printed+string > signature.asc

[VOTE] KIP-160: Augment KStream.print() to allow users pass in extra parameters in the printed string

I had start a voting process for KIP-160 https://cwiki.apache.org/confluence/display/KAFKA/KIP-160:+Augment+KStream.print()+to+allow+users+pass+in+extra+parameters+in+the+printed+string