Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

2017-07-26 Thread Bill Bejeck
The re-vote has now passed. The votes where: Binding +1: Sriram, Guozhang, Damian Non-binding +1: Matthias. The discussion wrapping up in this PR https://github.com/apache/kafka/pull/3325 -Bill On Wed, Jul 26, 2017 at 10:10 AM, Damian Guy wrote: > +1 > > On Tue, 25 Jul

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

2017-07-26 Thread Damian Guy
+1 On Tue, 25 Jul 2017 at 18:17 Sriram Subramanian wrote: > +1 > > On Fri, Jul 21, 2017 at 12:08 PM, Guozhang Wang > wrote: > > > +1 > > > > On Thu, Jul 20, 2017 at 11:00 PM, Matthias J. Sax > > > wrote: > > > > > +1 > > > > > >

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

2017-07-25 Thread Sriram Subramanian
+1 On Fri, Jul 21, 2017 at 12:08 PM, Guozhang Wang wrote: > +1 > > On Thu, Jul 20, 2017 at 11:00 PM, Matthias J. Sax > wrote: > > > +1 > > > > On 7/20/17 4:22 AM, Bill Bejeck wrote: > > > Hi, > > > > > > After working on the PR for this KIP I

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

2017-07-21 Thread Guozhang Wang
+1 On Thu, Jul 20, 2017 at 11:00 PM, Matthias J. Sax wrote: > +1 > > On 7/20/17 4:22 AM, Bill Bejeck wrote: > > Hi, > > > > After working on the PR for this KIP I discovered that we need to add and > > additional parameter (TopicPartition) to the StateRestoreListener >

Re: [VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

2017-07-21 Thread Matthias J. Sax
+1 On 7/20/17 4:22 AM, Bill Bejeck wrote: > Hi, > > After working on the PR for this KIP I discovered that we need to add and > additional parameter (TopicPartition) to the StateRestoreListener interface > methods. > > The addition of the TopicPartition is required as the StateRestoreListener >

[VOTE] KIP-167 (Addendum): Add interface for the state store restoration process

2017-07-19 Thread Bill Bejeck
Hi, After working on the PR for this KIP I discovered that we need to add and additional parameter (TopicPartition) to the StateRestoreListener interface methods. The addition of the TopicPartition is required as the StateRestoreListener is for the entire application, thus all tasks with