Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

While working on the follow up PR to deprecate `through()`, I realized that we forgot to add `repartition()` to the Scala API. I updated the KIP accordingly and my PR also include the update to the Scala API (for adding `repartition()` and deprecating `through()`): https://github.com/apache/kafka/

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Thanks Levani! I took the liberty to update the KIP accordingly, because so far no concerns were raised about the change. Also assigned the ticket to myself (let me know if you want to work on it instead). We should get the change into 2.6 release. -Matthias On 5/15/20 1:34 AM, Levani Kokhrei

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Hi Matthias, Thanks for your thoughts and sorry for taking so long to respond. For me that makes total sense, so +1 from my side. I took the liberty of creating a ticket for it: https://issues.apache.org/jira/browse/KAFKA-10003 Regards, Levan

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Sounds fair to me; I think as a syntax sugar it is a good to have, but sometimes it was "enforced" to be used for repartitioning purposes. On Mon, May 11, 2020 at 7:08 PM Matthias J. Sax wrote: > As an afterthought to KIP-221, I am wondering if we should deprecate > `KStream#through()`? > > The

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

As an afterthought to KIP-221, I am wondering if we should deprecate `KStream#through()`? The reasoning is that I assume that most people don't want to manage topics manually anyway and thus it might be good to guide users to use repartition(). Furthermore, through() is really just syntactic sugar

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Thanks for the update, Levani! -John On Sat, Apr 4, 2020, at 04:36, Levani Kokhreidze wrote: > Hello, > > Small update regarding this KIP. As per John’s suggestion during the > code review > (https://github.com/apache/kafka/pull/7170#discussion_r392608571 >

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Hello, Small update regarding this KIP. As per John’s suggestion during the code review (https://github.com/apache/kafka/pull/7170#discussion_r392608571 ) we’ve decided to remove KeyValueMapper overloads for the new `repartition`

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Thank you all! The vote has been open for ~8 days. KIP has three binding votes (Bill, Guozhang, Matthias) and one non-binding (Sophie) so the KIP vote passes! I’ll mark KIP as accepted and start working on it as soon as possible! Regards, Levani > On Aug 1, 2019, at 2:37 AM, Matthias J. Sax wr

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

+1 (binding) On 7/31/19 8:36 AM, Guozhang Wang wrote: > Thanks for the update! +1 (binding). > > On Tue, Jul 30, 2019 at 11:42 PM Levani Kokhreidze > wrote: > >> Hello Guozhang, >> >> Thanks for the feedback. That’s an interesting point. To be honest, I >> totally missed it. I wasn’t aware that

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Thanks for the update! +1 (binding). On Tue, Jul 30, 2019 at 11:42 PM Levani Kokhreidze wrote: > Hello Guozhang, > > Thanks for the feedback. That’s an interesting point. To be honest, I > totally missed it. I wasn’t aware that there’s `groupBy` possibility on > KTable. > I don’t see any reasons

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Hello Guozhang, Thanks for the feedback. That’s an interesting point. To be honest, I totally missed it. I wasn’t aware that there’s `groupBy` possibility on KTable. I don’t see any reasons why not to add same functionality to KTable interface. I’ve updated the KIP: https://cwiki.apache.org/co

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Hello Levani, Thanks for the KIP! Just got a quick question here about the scope: why do we only want this for `KStream`, not `KTable#groupBy` for example? Guozhang On Tue, Jul 30, 2019 at 1:27 PM Bill Bejeck wrote: > Thanks for the KIP Levani. > > +1 (binding) > > -Bill > > On Tue, Jul 30,

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Thanks for the KIP Levani. +1 (binding) -Bill On Tue, Jul 30, 2019 at 3:37 PM Levani Kokhreidze wrote: > Hello, > > Still waiting for feedback on this KIP. > Please let me know if you have any concerns and/or questions. > > Regards, > Levani > > > > On Jul 24, 2019, at 8:20 PM, Sophie Blee-Gol

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Hello, Still waiting for feedback on this KIP. Please let me know if you have any concerns and/or questions. Regards, Levani > On Jul 24, 2019, at 8:20 PM, Sophie Blee-Goldman wrote: > > Looks good! Thanks Levani, > > +1 (non-binding) > > Sophie > > On Tue, Jul 23, 2019 at 2:16 PM Levani K

Re: [VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Looks good! Thanks Levani, +1 (non-binding) Sophie On Tue, Jul 23, 2019 at 2:16 PM Levani Kokhreidze wrote: > Hello, > > I’d like to initialize voting on KIP-221: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-221%3A+Enhance+KStream+with+Connecting+Topic+Creation+and+Repartition+Hint

[VOTE] KIP-221: Enhance KStream with Connecting Topic Creation and Repartition Hint

Hello, I’d like to initialize voting on KIP-221: https://cwiki.apache.org/confluence/display/KAFKA/KIP-221%3A+Enhance+KStream+with+Connecting+Topic+Creation+and+Repartition+Hint