One minor change to the KIP. The class TopologyTestDriver will be in
package `org.apache.kafka.streams` (instead of `o.a.k.streams.test`).
+1 (binding).
I am closing this vote as accepted with 3 binding votes (Damian,
Guozhang, Matthias) and 2 non-binding votes (Bill, James).
Thanks for the
I added the new method to the KIP and also updated the PR.
-Matthias
On 1/18/18 10:48 AM, Guozhang Wang wrote:
> @Matthias
>
> This comes to me while reviewing another using the test driver: could we
> add a `Map allStateStores()` to the
> `TopologyTestDriver` besides all
@Matthias
This comes to me while reviewing another using the test driver: could we
add a `Map allStateStores()` to the
`TopologyTestDriver` besides all the get-store-by-name functions? This is
because some of the internal state stores may be implicitly created but
users may
+1 (non-binding)
-James
Sent from my iPhone
> On Jan 17, 2018, at 6:09 PM, Matthias J. Sax wrote:
>
> Hi,
>
> I would like to start the vote for KIP-247:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-247%3A+Add+public+test+utils+for+Kafka+Streams
>
>
>
Thanks for the KIP.
+1
-Bill
On Wed, Jan 17, 2018 at 9:09 PM, Matthias J. Sax
wrote:
> Hi,
>
> I would like to start the vote for KIP-247:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 247%3A+Add+public+test+utils+for+Kafka+Streams
>
>
> -Matthias
>
>
+1
On Thu, 18 Jan 2018 at 15:14 Bill Bejeck wrote:
> Thanks for the KIP.
>
> +1
>
> -Bill
>
> On Wed, Jan 17, 2018 at 9:09 PM, Matthias J. Sax
> wrote:
>
> > Hi,
> >
> > I would like to start the vote for KIP-247:
> >
Hi,
I would like to start the vote for KIP-247:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-247%3A+Add+public+test+utils+for+Kafka+Streams
-Matthias
signature.asc
Description: OpenPGP digital signature