Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

Hi, I just wanted to remind everybody that the this KIP has been accepted. The only thing left is for it to pass PR reviews and get merged for 2.1. PR: https://github.com/apache/kafka/pull/5439 On Fri, Aug 24, 2018 at 11:12 AM Stanislav Kozlovski wrote: > Hi Jun, > > Yes, my intention was to

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

Hi Jun, Yes, my intention was to have them per logDir but I failed to mention it in the KIP. Updated. Thanks, Stan On Fri, Aug 24, 2018 at 12:00 AM Jun Rao wrote: > Hi, Stan, > > Thanks for the KIP. Looks good to me overall. Just one comment below. > > uncleanable-partitions-count is per

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

Hi, Stan, Thanks for the KIP. Looks good to me overall. Just one comment below. uncleanable-partitions-count is per logDir, but uncleanable-bytes is not. Should we make them consistent? Jun On Wed, Aug 22, 2018 at 4:15 AM, Stanislav Kozlovski wrote: > Hi everybody, > > @Jason - I've updated

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

Hi everybody, @Jason - I've updated the section. Thanks for the reminder I'm glad to say that the vote *has passed* with 3 binding votes (Jason, Gwen, Harsha) and 6 non-binding votes (Dhruvil, Colin, Mickael, Manikumar, Ray, Ted, Thomas). The PR is ready for review at

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 Thanks for the KIP! I'd suggest mentioning the configurations that were previously proposed in the rejected alternatives section. We may reconsider them in the future. On Mon, Aug 13, 2018 at 9:48 AM, Dhruvil Shah wrote: > Thanks for the KIP, Stanislav! +1 (non-binding) > > - Dhruvil > > On

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

Thanks for the KIP, Stanislav! +1 (non-binding) - Dhruvil On Mon, Aug 13, 2018 at 9:39 AM Colin McCabe wrote: > +1 (non-binding) > > best, > Colin > > On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote: > > Hey everybody, > > I'm starting a vote on KIP-346 > > < >

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 (non-binding) best, Colin On Tue, Aug 7, 2018, at 04:19, Stanislav Kozlovski wrote: > Hey everybody, > I'm starting a vote on KIP-346 > > > -- > Best, > Stanislav

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 (non-binding) Thanks for the KIP! On Tue, Aug 7, 2018 at 6:53 PM Gwen Shapira wrote: > > +1 (binding) > > On Tue, Aug 7, 2018 at 4:19 AM, Stanislav Kozlovski > wrote: > > > Hey everybody, > > I'm starting a vote on KIP-346 > > >

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 (binding) On Tue, Aug 7, 2018 at 4:19 AM, Stanislav Kozlovski wrote: > Hey everybody, > I'm starting a vote on KIP-346 > 346+-+Improve+LogCleaner+behavior+on+error> > > -- > Best, > Stanislav > -- *Gwen Shapira* Product Manager |

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 (binding) Thanks, Harsha On Tue, Aug 7, 2018, at 10:22 AM, Manikumar wrote: > +1 (non-binding) > > Thanks for the KIP. > > On Tue, Aug 7, 2018 at 10:42 PM Ray Chiang wrote: > > > +1 (non-binding) > > > > -Ray > > > > On 8/7/18 9:26 AM, Ted Yu wrote: > > > +1 > > > > > > On Tue, Aug 7,

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 (non-binding) Thanks for the KIP. On Tue, Aug 7, 2018 at 10:42 PM Ray Chiang wrote: > +1 (non-binding) > > -Ray > > On 8/7/18 9:26 AM, Ted Yu wrote: > > +1 > > > > On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker > wrote: > > > >> +1 (non-binding) > >> > >> We've hit issues with the log

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 (non-binding) -Ray On 8/7/18 9:26 AM, Ted Yu wrote: +1 On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker wrote: +1 (non-binding) We've hit issues with the log cleaner in the past, and this would be a great improvement. On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote: Hey

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 On Tue, Aug 7, 2018 at 5:25 AM Thomas Becker wrote: > +1 (non-binding) > > We've hit issues with the log cleaner in the past, and this would be a > great improvement. > On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote: > > Hey everybody, > > I'm starting a vote on KIP-346 > > < >

Re: [VOTE] KIP-346 - Improve LogCleaner behavior on error

+1 (non-binding) We've hit issues with the log cleaner in the past, and this would be a great improvement. On Tue, 2018-08-07 at 12:19 +0100, Stanislav Kozlovski wrote: Hey everybody, I'm starting a vote on KIP-346

[VOTE] KIP-346 - Improve LogCleaner behavior on error

Hey everybody, I'm starting a vote on KIP-346 -- Best, Stanislav