Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-10-03 Thread Bill Bejeck
All, One additional minor change "Grouped.named" has been changed to "Grouped.as". I've updated the KIP with this change. Thanks, Bill

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-28 Thread Bill Bejeck
All, I've made a slight adjustment to the KIP and changed the "Joined.name" to "Joined.named" Thanks, Bill On Thu, Sep 20, 2018 at 4:49 PM Bill Bejeck wrote: > Hi All, > > KIP-372 is now accepted with: > - 3 Binding +1 (Damian, Guozhang, Matthias) > - 3 Non-binding +1 (Dongjin, John, Bill) >

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-20 Thread Bill Bejeck
Hi All, KIP-372 is now accepted with: - 3 Binding +1 (Damian, Guozhang, Matthias) - 3 Non-binding +1 (Dongjin, John, Bill) Thanks to everyone for the votes. -Bill On Thu, Sep 20, 2018 at 7:30 AM Damian Guy wrote: > +1 (binding) > > On Tue, 18 Sep 2018 at 16:33 Bill Bejeck wrote: > > > All,

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-20 Thread Damian Guy
+1 (binding) On Tue, 18 Sep 2018 at 16:33 Bill Bejeck wrote: > All, > > In starting work on the PR for KIP-372, the Grouped interface needed some > method renaming to be more consistent with the other configuration classes > (Joined, Produced, etc.). As such I've updated the Grouped code

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-18 Thread Bill Bejeck
All, In starting work on the PR for KIP-372, the Grouped interface needed some method renaming to be more consistent with the other configuration classes (Joined, Produced, etc.). As such I've updated the Grouped code section of the KIP. As these changes address a comment from Matthias on the

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-18 Thread John Roesler
+1 (non-binding) Thanks! On Mon, Sep 17, 2018 at 7:29 PM Dongjin Lee wrote: > Great improvements. +1. (Non-binding) > > On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax > wrote: > > > +1 (binding) > > > > -Matthias > > > > On 9/17/18 1:12 PM, Guozhang Wang wrote: > > > +1 from me, thanks Bill

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-17 Thread Dongjin Lee
Great improvements. +1. (Non-binding) On Tue, Sep 18, 2018 at 5:14 AM Matthias J. Sax wrote: > +1 (binding) > > -Matthias > > On 9/17/18 1:12 PM, Guozhang Wang wrote: > > +1 from me, thanks Bill ! > > > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck wrote: > > > >> All, > >> > >> I'd like to

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-17 Thread Matthias J. Sax
+1 (binding) -Matthias On 9/17/18 1:12 PM, Guozhang Wang wrote: > +1 from me, thanks Bill ! > > On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck wrote: > >> All, >> >> I'd like to start the voting process for KIP-372. Here's the link to the >> updated proposal >>

Re: [VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-17 Thread Guozhang Wang
+1 from me, thanks Bill ! On Mon, Sep 17, 2018 at 12:43 PM, Bill Bejeck wrote: > All, > > I'd like to start the voting process for KIP-372. Here's the link to the > updated proposal > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

[VOTE] KIP-372: Naming Repartition Topics for Joins and Grouping

2018-09-17 Thread Bill Bejeck
All, I'd like to start the voting process for KIP-372. Here's the link to the updated proposal https://cwiki.apache.org/confluence/display/KAFKA/KIP-372%3A+Naming+Repartition+Topics+for+Joins+and+Grouping I'll start with my own +1. Thanks, Bill