Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-15 Thread Guozhang Wang
+1 from myself. Thanks for everyone for the feedbacks / votes. I'm closing this voting thread with 3 binding votes (Damian, Matthias, Guozhang) and 3 non-binding votes (John, Bill, Boyang). Guozhang On Sun, Jan 13, 2019 at 11:42 AM Guozhang Wang wrote: > Hello Matthias, > > I added here

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-13 Thread Guozhang Wang
rg/confluence/display/KAFKA/KIP-414%3A+Notify+SourceTask+of+ACK%27d+offsets%2C+metadata, > maybe you want to resolve this conflict with him? > > Best, > Boyang > > > From: Matthias J. Sax > Sent: Sunday, January 13, 2019 10:30 AM > To: dev@

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-13 Thread Guozhang Wang
Hello Matthias, I added here since in the original KIP-345 this API was brought up once for the similar purpose. I agree this may cause more confusions than clarifications so I'll remove this. Guozhang On Sat, Jan 12, 2019 at 6:30 PM Matthias J. Sax wrote: > Thanks for the KIP. > > One side

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-12 Thread Boyang Chen
, January 13, 2019 10:30 AM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams Thanks for the KIP. One side comment about rejected alternatives. I would remove the sentence, because `StreamsMetadata` is part of IQ feature and not related at all

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-12 Thread Matthias J. Sax
Thanks for the KIP. One side comment about rejected alternatives. I would remove the sentence, because `StreamsMetadata` is part of IQ feature and not related at all to this change -- thus, it does not seem to be a valid alternative. +1 (binding) -Matthias On 1/11/19 5:47 AM, Bill Bejeck

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-11 Thread Bill Bejeck
Thanks for the KIP Guozhang, +1 for me. On Fri, Jan 11, 2019 at 7:10 AM Damian Guy wrote: > +1 > > On Fri, 11 Jan 2019 at 05:09, John Roesler wrote: > > > Hi Guozhang, > > > > It sounds reasonable to me. I'm +1 (nonbinding). > > > > -John > > > > On Tue, Jan 8, 2019 at 8:51 PM Guozhang Wang

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-11 Thread Damian Guy
+1 On Fri, 11 Jan 2019 at 05:09, John Roesler wrote: > Hi Guozhang, > > It sounds reasonable to me. I'm +1 (nonbinding). > > -John > > On Tue, Jan 8, 2019 at 8:51 PM Guozhang Wang wrote: > > > Hello folks, > > > > I'd like to start a voting process for the following KIP: > > > > > > >

Re: [VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-10 Thread John Roesler
Hi Guozhang, It sounds reasonable to me. I'm +1 (nonbinding). -John On Tue, Jan 8, 2019 at 8:51 PM Guozhang Wang wrote: > Hello folks, > > I'd like to start a voting process for the following KIP: > > >

[VOTE] KIP-414: Expose Embedded ClientIds in Kafka Streams

2019-01-08 Thread Guozhang Wang
Hello folks, I'd like to start a voting process for the following KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-414%3A+Expose+Embedded+ClientIds+in+Kafka+Streams It is a pretty straight-forward and small augment to Stream's public ThreadMetadata interface, as an outcome of the