Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-05-06 Thread John Roesler
You're absolutely right. I realized that at some point after the initial message and just tried to play it cool. Sorry about that. -John On Mon, Apr 15, 2019 at 11:59 AM Jun Rao wrote: > The voting thread seems to be referring to the wrong KIP number. It should > be KIP-442 instead of KIP-422.

Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-04-15 Thread Jun Rao
The voting thread seems to be referring to the wrong KIP number. It should be KIP-442 instead of KIP-422. Thanks, Jun On Wed, Apr 3, 2019 at 7:03 PM John Roesler wrote: > Thanks all. The KIP-442 vote has passed with 3 binding votes (Guozhang, > Bill, and Damian) and one non-binding vote (me)

Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-04-03 Thread John Roesler
Thanks all. The KIP-442 vote has passed with 3 binding votes (Guozhang, Bill, and Damian) and one non-binding vote (me) in favor and none against. I'll update the KIP page. -John On Fri, Mar 29, 2019 at 10:29 AM Damian Guy wrote: > +1 > > On Wed, 27 Mar 2019 at 21:38, John Roesler wrote: > >

Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-03-29 Thread Damian Guy
+1 On Wed, 27 Mar 2019 at 21:38, John Roesler wrote: > Ah, good point, Guozhang. I'll remove that mention from the KIP. > > On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck wrote: > > > +1 for me, > > > > Thanks, > > Bill > > > > On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang > wrote: > > > > > +1

Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-03-27 Thread John Roesler
Ah, good point, Guozhang. I'll remove that mention from the KIP. On Wed, Mar 27, 2019 at 3:30 PM Bill Bejeck wrote: > +1 for me, > > Thanks, > Bill > > On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang wrote: > > > +1 from me. > > > > Though note that we cannot make such changes in older versions

Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-03-27 Thread Bill Bejeck
+1 for me, Thanks, Bill On Wed, Mar 27, 2019 at 4:13 PM Guozhang Wang wrote: > +1 from me. > > Though note that we cannot make such changes in older versions since even > if we release new versions out of those branches they are considered > bug-fix only and hence should not have any interface

Re: [VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-03-27 Thread Guozhang Wang
+1 from me. Though note that we cannot make such changes in older versions since even if we release new versions out of those branches they are considered bug-fix only and hence should not have any interface impacting changes. Guozhang On Wed, Mar 27, 2019 at 12:55 PM John Roesler wrote: >

[VOTE] KIP-422: Use the default value of max.poll.interval in Streams

2019-03-27 Thread John Roesler
Hi all, Since the KIP is so small, I'm going to optimistically start the vote for KIP-422 to remove our "max int" default max.poll.interval.ms in Streams and fall back to the Consumer default of five minutes.