Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-30 Thread Colin McCabe
On Sat, Sep 28, 2019, at 17:49, Magnus Edenhill wrote: > Den mån 23 sep. 2019 kl 14:42 skrev Colin McCabe : > > > On Fri, Sep 20, 2019, at 18:05, Jun Rao wrote: > > > 101. We already use varInt in the message format. I assume that the > > > protocol uses the same varInt representation? > > > > It

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-28 Thread Magnus Edenhill
Den mån 23 sep. 2019 kl 14:42 skrev Colin McCabe : > On Fri, Sep 20, 2019, at 18:05, Jun Rao wrote: > > 101. We already use varInt in the message format. I assume that the > > protocol uses the same varInt representation? > > It uses a slightly different varint representation. Basically, the >

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-23 Thread Colin McCabe
gt; > > > > > > > On Wed, Sep 04, 2019 at 1:46 AM, Satish Duggana < > > > > > > satish.dugg...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > +1 (non-binding) Thanks for the nice KIP. &g

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-20 Thread Jun Rao
> > > > > > > > > > > > +1 (non-binding) Thanks for the nice KIP. > > > > > > > > > > > > > > You may want to update the KIP saying that optional tagged > fields > > > do > > > > &

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-06 Thread Colin McCabe
ng that optional tagged fields > > do > > > > not > > > > > > support complex types(or structs). > > > > > > > > > > > > On Wed, Sep 4, 2019 at 3:43 AM Jose Armando Garcia Sancio > > > > > >

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-06 Thread Jason Gustafson
t; > > > support complex types(or structs). > > > > > > > > > > On Wed, Sep 4, 2019 at 3:43 AM Jose Armando Garcia Sancio > > > > > wrote: > > > > > > > > > > +1 (non-binding) > > > > > > &

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-04 Thread Colin McCabe
Garcia Sancio > > > > wrote: > > > > > > > > +1 (non-binding) > > > > > > > > Looking forward to this improvement. > > > > > > > > On Tue, Sep 3, 2019 at 12:49 PM David Jacot > > wrote: > >

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-04 Thread Jason Gustafson
+1 (non-binding) > > > > > > Thank for the KIP. Great addition to the Kafka protocol! > > > > > > Best, > > > David > > > > > > Le mar. 3 sept. 2019 à 19:17, Colin McCabe a > écrit > > : > > > > >

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-04 Thread David Arthur
mprovement. > > > > On Tue, Sep 3, 2019 at 12:49 PM David Jacot wrote: > > > > +1 (non-binding) > > > > Thank for the KIP. Great addition to the Kafka protocol! > > > > Best, > > David > > > > Le mar. 3 sept. 2019 à 19:17, Colin McCa

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-04 Thread Harsha Chintalapani
> Le mar. 3 sept. 2019 à 19:17, Colin McCabe a écrit : > > Hi all, > > I'd like to start the vote for KIP-482: The Kafka Protocol should Support > Optional Tagged Fields. > > KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/ > KIP-482%3A+The+Kafka+Protoco

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-04 Thread Satish Duggana
> On Tue, Sep 3, 2019 at 12:49 PM David Jacot wrote: > > > +1 (non-binding) > > > > Thank for the KIP. Great addition to the Kafka protocol! > > > > Best, > > David > > > > Le mar. 3 sept. 2019 à 19:17, Colin McCabe a écrit : > > > >

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-03 Thread Jose Armando Garcia Sancio
gt; > Hi all, > > > > I'd like to start the vote for KIP-482: The Kafka Protocol should Support > > Optional Tagged Fields. > > > > KIP: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagg

Re: [VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-03 Thread David Jacot
+1 (non-binding) Thank for the KIP. Great addition to the Kafka protocol! Best, David Le mar. 3 sept. 2019 à 19:17, Colin McCabe a écrit : > Hi all, > > I'd like to start the vote for KIP-482: The Kafka Protocol should Support > Optional Tagged Fields. > > KIP: > htt

[VOTE] KIP-482: The Kafka Protocol should Support Optional Tagged Fields

2019-09-03 Thread Colin McCabe
Hi all, I'd like to start the vote for KIP-482: The Kafka Protocol should Support Optional Tagged Fields. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagged+Fields Discussion thread here: https://lists.apache.org/thread.html