Re: [VOTE] KIP-524: Allow users to choose config source when describing configs

2019-10-09 Thread Jason Gustafson
I'm going to close this vote. Thanks for the reviews! The total is +5 total with +4 binding. -Jason On Wed, Sep 25, 2019 at 12:34 PM Harsha Chintalapani wrote: > Thanks for the KIP. +1 (binding). > > -Harsha > > On Wed, Sep 25, 2019 at 11:55 AM Satish Duggana > wrote: > > > Thanks Jason for

Re: [VOTE] KIP-524: Allow users to choose config source when describing configs

2019-09-25 Thread Harsha Chintalapani
Thanks for the KIP. +1 (binding). -Harsha On Wed, Sep 25, 2019 at 11:55 AM Satish Duggana wrote: > Thanks Jason for the KIP. It looks to be a minor improvement but very > useful. > > +1 (non-binding) > > On Wed, Sep 25, 2019 at 9:29 PM Rajini Sivaram > wrote: > > > > Thanks for the KIP,

Re: [VOTE] KIP-524: Allow users to choose config source when describing configs

2019-09-25 Thread Satish Duggana
Thanks Jason for the KIP. It looks to be a minor improvement but very useful. +1 (non-binding) On Wed, Sep 25, 2019 at 9:29 PM Rajini Sivaram wrote: > > Thanks for the KIP, Jason! > > +1 (binding) > > Regards, > > Rajini > > On Wed, Sep 25, 2019 at 4:41 PM Colin McCabe wrote: > > > Looks good.

Re: [VOTE] KIP-524: Allow users to choose config source when describing configs

2019-09-25 Thread Rajini Sivaram
Thanks for the KIP, Jason! +1 (binding) Regards, Rajini On Wed, Sep 25, 2019 at 4:41 PM Colin McCabe wrote: > Looks good. +1 (binding) > > best, > Colin > > On Tue, Sep 24, 2019, at 09:42, Jason Gustafson wrote: > > Hi All, > > > > I'm starting a vote for KIP-524, which is a small change to

Re: [VOTE] KIP-524: Allow users to choose config source when describing configs

2019-09-25 Thread Colin McCabe
Looks good. +1 (binding) best, Colin On Tue, Sep 24, 2019, at 09:42, Jason Gustafson wrote: > Hi All, > > I'm starting a vote for KIP-524, which is a small change to the config > tool: >

[VOTE] KIP-524: Allow users to choose config source when describing configs

2019-09-24 Thread Jason Gustafson
Hi All, I'm starting a vote for KIP-524, which is a small change to the config tool: https://cwiki.apache.org/confluence/display/KAFKA/KIP-524%3A+Allow+users+to+choose+config+source+when+describing+configs . +1 from me. Thanks, Jason