Re: [VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-15 Thread Randall Hauch
This KIP is now accepted. The vote has been open for >72 hours (actually 8 days), and we have four binding +1s (Konstantine, Bill, John, me), one non-binding +1 (Chris), and no -1 votes. Thanks, everyone! On Fri, May 15, 2020 at 12:13 PM John Roesler wrote: > Thanks for the KIP, Randall! > > I'

Re: [VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-15 Thread John Roesler
Thanks for the KIP, Randall! I've just taken a look, and I'm +1 (binding) as well. Thanks, -John On Fri, May 15, 2020, at 11:50, Bill Bejeck wrote: > Thanks for clear KIP Randall, it clearly demonstrates the need for this > change. > > +1 (binding) > > -Bill > > On Tue, May 12, 2020 at 2:02 P

Re: [VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-15 Thread Bill Bejeck
Thanks for clear KIP Randall, it clearly demonstrates the need for this change. +1 (binding) -Bill On Tue, May 12, 2020 at 2:02 PM Randall Hauch wrote: > FYI: I made a few clarifications to more carefully describe what happens > with extra topic settings that the broker doesn't accept. > > Fir

Re: [VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-12 Thread Randall Hauch
FYI: I made a few clarifications to more carefully describe what happens with extra topic settings that the broker doesn't accept. First, the description in the patterns table now is a bit more clear: Here "" must be any valid Kafka topic-level configurations for the version of the Kafka broker w

Re: [VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-11 Thread Konstantine Karantasis
This KIP falls in the category of necessary and straightforward KIPs. Thanks for the nice write-up Randall. +1 (binding) Konstantine On Mon, May 11, 2020 at 8:00 AM Randall Hauch wrote: > Ping for reviewers. > > I guess I never voted, so +1 (binding). > > On Thu, May 7, 2020 at 4:13 PM Christo

Re: [VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-11 Thread Randall Hauch
Ping for reviewers. I guess I never voted, so +1 (binding). On Thu, May 7, 2020 at 4:13 PM Christopher Egerton wrote: > LGTM, +1 (non-binding) > > Thanks Randall! > > On Thu, May 7, 2020 at 11:01 AM Randall Hauch wrote: > > > I'd like to open the vote for KIP-605: > > > > > https://cwiki.apach

Re: [VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-07 Thread Christopher Egerton
LGTM, +1 (non-binding) Thanks Randall! On Thu, May 7, 2020 at 11:01 AM Randall Hauch wrote: > I'd like to open the vote for KIP-605: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-605%3A+Expand+Connect+Worker+Internal+Topic+Settings > > This is relatively straightforward, and the dis

[VOTE] KIP-605 - Expand Connect Worker Internal Topic Settings

2020-05-07 Thread Randall Hauch
I'd like to open the vote for KIP-605: https://cwiki.apache.org/confluence/display/KAFKA/KIP-605%3A+Expand+Connect+Worker+Internal+Topic+Settings This is relatively straightforward, and the discussion thread had just a few suggestions that have already been incorporated into the KIP. Best regards