Re: [VOTE] KIP-610: Error Reporting in Sink Connectors

2020-06-05 Thread Randall Hauch
Thanks again to everyone for all the work on this KIP and implementation! I've discovered that it would be easier for downstream projects if the new `SinkTaskContext.errantRecordReporter()` method were a default method that returns null. Strictly speaking it's not required as Connect will provide

Re: [VOTE] KIP-610: Error Reporting in Sink Connectors

2020-05-21 Thread Randall Hauch
The vote has been open for >72 hours, and the KIP is adopted with three +1 binding votes (Konstantine, Ewen, me), one +1 non-binding vote (Andrew), and no -1 votes. I'll update the KIP and the AK 2.6.0 plan. Thanks, everyone. On Tue, May 19, 2020 at 4:33 PM Konstantine Karantasis < konstant...@c

Re: [VOTE] KIP-610: Error Reporting in Sink Connectors

2020-05-19 Thread Konstantine Karantasis
+1 (binding) I like how the KIP looks now too. Quite active discussions within the past few days, which I found very useful. There's some room to allow in the future the connector developers to decide whether they want greater control over error reporting or they want the framework to keep provid

Re: [VOTE] KIP-610: Error Reporting in Sink Connectors

2020-05-19 Thread Ewen Cheslack-Postava
+1 (binding) This will be a nice improvement. From the discussion thread it's clear this is tricky to get right, nice work! On Tue, May 19, 2020 at 8:16 AM Andrew Schofield wrote: > +1 (non-binding) > > This is now looking very nice. > > Andrew Schofield > > On 19/05/2020, 16:11, "Randall Hauc

Re: [VOTE] KIP-610: Error Reporting in Sink Connectors

2020-05-19 Thread Andrew Schofield
+1 (non-binding) This is now looking very nice. Andrew Schofield On 19/05/2020, 16:11, "Randall Hauch" wrote: Thank you, Aakash, for putting together this KIP and shepherding the discussion. Also, many thanks to all those that participated in the very active discussion. I'm actual

Re: [VOTE] KIP-610: Error Reporting in Sink Connectors

2020-05-19 Thread Randall Hauch
Thank you, Aakash, for putting together this KIP and shepherding the discussion. Also, many thanks to all those that participated in the very active discussion. I'm actually very happy with the current proposal, am confident that it is a valuable improvement to the Connect framework, and know that

[VOTE] KIP-610: Error Reporting in Sink Connectors

2020-05-17 Thread Aakash Shah
Hello all, I'd like to open a vote for KIP-610: https://cwiki.apache.org/confluence/display/KAFKA/KIP-610%3A+Error+Reporting+in+Sink+Connectors Thanks, Aakash