Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-11-06 Thread David Mao
Hi all, I updated the KIP with more details on per-IP connection rate limiting. Notable changes are the addition of metrics tracking per-IP connection rate acceptance and IP connection rate limiting throttling. In addition, I fleshed out details around the API we will use to describe and alter

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-11-03 Thread Anna Povzner
Hi David, You are right, using a token bucket exposes the metric for the number of remaining tokens in the bucket. Since we also want to evaluate using a token bucket for bandwidth & request throttling, it would be better to have this discussion separately in a separate KIP. This KIP does not

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-09-02 Thread David Jacot
Hi Anna, Thanks for the update. If you use Token Bucket, it will expose another metric which reports the number of remaining tokens in the bucket, in addition to the current rate metric. It would be great to add it in the metrics section of the KIP as well for completeness. Best, David On Tue,

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-08-10 Thread Anna Povzner
Hi All, I wanted to let everyone know that we would like to make the following changes to the KIP: 1. Expose connection acceptance rate metrics (broker-wide and per-listener) and per-listener average throttle time metrics for better observability and debugging. 2. KIP-599

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-21 Thread Anna Povzner
The vote for KIP-612 has passed with 3 binding and 3 non-binding +1s, and no objections. Thanks everyone for reviews and feedback, Anna On Tue, May 19, 2020 at 2:41 AM Rajini Sivaram wrote: > +1 (binding) > > Thanks for the KIP, Anna! > > Regards, > > Rajini > > > On Tue, May 19, 2020 at

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-19 Thread Rajini Sivaram
+1 (binding) Thanks for the KIP, Anna! Regards, Rajini On Tue, May 19, 2020 at 9:32 AM Alexandre Dupriez < alexandre.dupr...@gmail.com> wrote: > +1 (non-binding) > > Thank you for the KIP! > > > Le mar. 19 mai 2020 à 07:57, David Jacot a écrit : > > > > +1 (non-binding) > > > > Thanks for

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-19 Thread Alexandre Dupriez
+1 (non-binding) Thank you for the KIP! Le mar. 19 mai 2020 à 07:57, David Jacot a écrit : > > +1 (non-binding) > > Thanks for the KIP, Anna! > > On Tue, May 19, 2020 at 7:12 AM Satish Duggana > wrote: > > > +1 (non-binding) > > Thanks Anna for the nice feature to control the connection

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-19 Thread David Jacot
+1 (non-binding) Thanks for the KIP, Anna! On Tue, May 19, 2020 at 7:12 AM Satish Duggana wrote: > +1 (non-binding) > Thanks Anna for the nice feature to control the connection creation rate > from the clients. > > On Tue, May 19, 2020 at 8:16 AM Gwen Shapira wrote: > > > +1 (binding) > > > >

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-18 Thread Satish Duggana
+1 (non-binding) Thanks Anna for the nice feature to control the connection creation rate from the clients. On Tue, May 19, 2020 at 8:16 AM Gwen Shapira wrote: > +1 (binding) > > Thank you for driving this, Anna > > On Mon, May 18, 2020 at 4:55 PM Anna Povzner wrote: > > > Hi All, > > > > I

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-18 Thread Gwen Shapira
+1 (binding) Thank you for driving this, Anna On Mon, May 18, 2020 at 4:55 PM Anna Povzner wrote: > Hi All, > > I would like to start the vote on KIP-612: Ability to limit connection > creation rate on brokers. > > For reference, here is the KIP wiki: > >

Re: [VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-18 Thread Harsha Ch
+1 (binding) On Mon, May 18 2020 at 4:54 PM, Anna Povzner < a...@confluent.io > wrote: > > > > Hi All, > > > > I would like to start the vote on KIP-612: Ability to limit connection > creation rate on brokers. > > > > For reference, here is the KIP wiki: >

[VOTE] KIP-612: Ability to Limit Connection Creation Rate on Brokers

2020-05-18 Thread Anna Povzner
Hi All, I would like to start the vote on KIP-612: Ability to limit connection creation rate on brokers. For reference, here is the KIP wiki: https://cwiki.apache.org/confluence/display/KAFKA/KIP-612%3A+Ability+to+Limit+Connection+Creation+Rate+on+Brokers And discussion thread: