I am making a minor update to the KIP renaming the TaskId#namedTopology
method to TaskId#topologyName as it returns a string for the name not an
object. This has approval to make it into 3.0 already.
https://github.com/apache/kafka/pull/11192
best,
Walker
On Thu, May 20, 2021 at 4:58 PM Sophie Bl
Thanks Bruno, fixed. Definitely a leftover from one of the many iterations
of this KIP.
Guozhang,
Thanks for pointing out the change in TaskMetadata constructor, I
definitely agree to
just swap out the constructor since that's not really the useful part of
this API. I'm more
on the fence when it c
Thanks for the updates, Sophie,
I'm +1 (binding)
-John
On Thu, 2021-05-20 at 12:54 +0200, Bruno Cadonna wrote:
> Thanks for the KIP, Sophie!
>
> +1 (binding)
>
> Note:
> The sentence in the KIP seems to need some corrections:
>
> "To migrate from the String to TaskIdInfo in TaskMetadata, we'l
Thanks for the KIP, Sophie!
+1 (binding)
Note:
The sentence in the KIP seems to need some corrections:
"To migrate from the String to TaskIdInfo in TaskMetadata, we'll need to
deprecate the existing taskId() getter method and add a TaskId() getter
in its place."
I guess you wanted to write:
A quick note: since we changed the constructor of TaskMetadata as well in
the PR, we'd need to add that in the KIP wiki as well. Personally I think
it is okay to just replace the constructor as you did in the PR rather than
adding/deprecating --- I would even advocate for replacing the `taskId`
fun
Thanks Sophie, I like the current proposal better compared to adding a new
TaskInfo class. +1 !
Guozhang
On Wed, May 19, 2021 at 4:58 PM Sophie Blee-Goldman
wrote:
> Just a friendly ping to please check out the finalized proposal of the KIP
> and (re)cast your votes
>
> Thanks!
> Sophie
>
> On
Just a friendly ping to please check out the finalized proposal of the KIP
and (re)cast your votes
Thanks!
Sophie
On Sun, May 16, 2021 at 7:28 PM Sophie Blee-Goldman
wrote:
> Thanks John. I have moved the discussion over to a [DISCUSS] thread, where
> it should have been taking place all
> alon
Thanks John. I have moved the discussion over to a [DISCUSS] thread, where
it should have been taking place all
along. I'll officially kick off the vote again, but since this KIP has been
through a significant overhauled since it's initial
proposal, the previous votes cast will be invalidated. Plea
Thanks for these updates, Sophie,
Unfortunately, I have some minor suggestions:
1. "Topic Group" is a vestigial term from the early days of
the codebase. We call a "topic group" a "subtopology" in the
public interface now (although "topic group" is still used
internally some places). For user-fac
One last update: we will not actually remove the existing
o.a.k.streams.processor.TaskId class, but only
deprecate it, along with any methods that returned it (ie the getters on
ProcessorContext and StateStoreContext)
Internally, everything will still be converted to use the new internal
TaskId cl
Thanks all. I updated the KIP slightly since there is some ambiguity around
whether the existing TaskId class is
currently part of the public API or not. To settle the matter, I have
introduced a new public TaskId interface that
exposes the metadata, and moved the existing TaskId class to the inter
+1
On a hindsight, maybe TaskId should not really be in
`org.apache.kafka.streams.processor` but rather just in `o.a.k.streams`,
but maybe not worth pulling it up now :)
Guozhang
On Thu, May 13, 2021 at 1:58 PM Walker Carlson
wrote:
> +1 from me! (non-binding)
>
> Walker
>
> On Thu, May 13, 20
+1 from me! (non-binding)
Walker
On Thu, May 13, 2021 at 1:53 PM Sophie Blee-Goldman
wrote:
> Hey all,
>
> I'm just going to take this KIP straight to a vote since it should be a
> trivial and uncontroversial change. Of course please raise any concerns
> should they come up, and I can take thin
Hey all,
I'm just going to take this KIP straight to a vote since it should be a
trivial and uncontroversial change. Of course please raise any concerns
should they come up, and I can take things to a DISCUSS thread.
The KIP is a simple change to move from String to TaskId for the taskID
field of
14 matches
Mail list logo
