Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi all, Thanks for participating. The feedback was really useful. I'm closing this vote with three binding +1 and zero -1 votes. Binding +1: — Bruno — Guozhang — Sophie Non-Binding +1: — Myself I hope I closed the vote the right way. Let me know if something I did was not correct. I'll start

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Thanks for the KIP! +1 (binding) -Sophie On Mon, Jun 7, 2021 at 11:19 AM Guozhang Wang wrote: > Thanks, that update LGTM. +1! > > Guozhang > > On Mon, Jun 7, 2021 at 9:45 AM Josep Prat > wrote: > > > Hi Guozhang, > > Let me know if the updated KIP meets your requests. And thanks again for > >

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Thanks, that update LGTM. +1! Guozhang On Mon, Jun 7, 2021 at 9:45 AM Josep Prat wrote: > Hi Guozhang, > Let me know if the updated KIP meets your requests. And thanks again for > your feedback! > > Thanks, > > On Sat, Jun 5, 2021 at 4:38 PM Josep Prat wrote: > > > Done, KIP is now updated to

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Guozhang, Let me know if the updated KIP meets your requests. And thanks again for your feedback! Thanks, On Sat, Jun 5, 2021 at 4:38 PM Josep Prat wrote: > Done, KIP is now updated to reflect this. > > On Sat, Jun 5, 2021 at 4:29 PM Josep Prat wrote: > >> Hi Guozhang, >> >> Thanks for

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Done, KIP is now updated to reflect this. On Sat, Jun 5, 2021 at 4:29 PM Josep Prat wrote: > Hi Guozhang, > > Thanks for your review, let's exclude the "localThreadsMetadata returning > StreamsMetadata" change then. This way, as well, this KIP is completely > consistent on making those Metadata

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Guozhang, Thanks for your review, let's exclude the "localThreadsMetadata returning StreamsMetadata" change then. This way, as well, this KIP is completely consistent on making those Metadata classes interfaces with internal implementations. I'll update the KIP document right away. Thanks for

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Josep, I think the most significant change would be, "localThreadsMetadata" returns a StreamsMetadata instead of ThreadMetadata, and StreamsMetadata would expose a new API to return a set of ThreadMetadata. All others (including the repackaging and splitting of interface / impl) are minor

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

A summary of the changes from previous version can be seen under Public Interfaces --> UPDATE On Sat, Jun 5, 2021 at 1:39 PM Josep Prat wrote: > Hi Guozhang, > I updated the KIP with, but I'm not so sure about your point 1, as from > the user's perspective, the API available to them will be

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Guozhang, I updated the KIP with, but I'm not so sure about your point 1, as from the user's perspective, the API available to them will be really different. If you think it's fine to introduce this change for the users, I'm happy to do that. If not, I can revert my KIP to remove your point 1).

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Guozhang, So if I understand correctly, it's only a couple of small changes that need to be made to this KIP to be aligned with KAFKA-12370, right? I'm guessing that StreamsMetadata would not only moved to o.a.k.streams but also be split with Interface + internal implementation, am I right?

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hello Josep, Thanks for the proposal! The write-up looks good to me in general. I'm just wondering if you feel comfortable to align this with another JIRA/KIP further down the road: https://issues.apache.org/jira/browse/KAFKA-12370 Which tries to clean up the metadata hierarchy and the callers

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Thanks, Josep! +1 (binding) Bruno On 04.06.21 10:27, Josep Prat wrote: Hi all, I'd like to call for a vote on KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation KIP page can be found here: https://cwiki.apache.org/confluence/x/XIrOCg Discussion

[VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi all, I'd like to call for a vote on KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation KIP page can be found here: https://cwiki.apache.org/confluence/x/XIrOCg Discussion thread can be found here: