Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2022-02-08 Thread Séamus Ó Ceanainn
> Hi Séamus, > > >> > > > Thanks for the KIP! > > >> > > > We definitely want to keep the producer callback consistent for > all > > >> types > > >> > > > of errors. > > >> > > > > > >> >

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2022-02-07 Thread Kirk True
gt; > >> > > > Just one comment for the KIP: > >> > > > In the "Proposed Changes" section, could you please "explicitly" > >> describe > >> > > > what placeholder you'll return, in addition to adding a hyperlink to > &

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2022-02-07 Thread Séamus Ó Ceanainn
the "Proposed Changes" section, could you please "explicitly" >> describe >> > > > what placeholder you'll return, in addition to adding a hyperlink to >> > > other >> > > > places, to make it cle

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2022-01-25 Thread Séamus Ó Ceanainn
t clear. > > > > > > > > +1 (non-binding) > > > > > > > > Thank you. > > > > Luke > > > > > > > > On Tue, Nov 30, 2021 at 1:17 PM John Roesler > > > wrote: > > > > > > > > > Thanks, Séamu

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-12-06 Thread Mickael Maison
t; > Thank you. > > > Luke > > > > > > On Tue, Nov 30, 2021 at 1:17 PM John Roesler > > wrote: > > > > > > > Thanks, Séamus! > > > > > > > > I'm +1 (binding). > > > > > > > > On Mon, 2021-11-29

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-12-03 Thread Luke Chen
. > > > > +1 (non-binding) > > > > Thank you. > > Luke > > > > On Tue, Nov 30, 2021 at 1:17 PM John Roesler > wrote: > > > > > Thanks, Séamus! > > > > > > I'm +1 (binding). > > > > > > On Mon, 2021-11-29 at 1

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-12-03 Thread Séamus Ó Ceanainn
; places, to make it clear. > > +1 (non-binding) > > Thank you. > Luke > > On Tue, Nov 30, 2021 at 1:17 PM John Roesler wrote: > > > Thanks, Séamus! > > > > I'm +1 (binding). > > > > On Mon, 2021-11-29 at 16:14 +, Séamus Ó Ceanainn wro

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-11-30 Thread Luke Chen
a hyperlink to other places, to make it clear. +1 (non-binding) Thank you. Luke On Tue, Nov 30, 2021 at 1:17 PM John Roesler wrote: > Thanks, Séamus! > > I'm +1 (binding). > > On Mon, 2021-11-29 at 16:14 +, Séamus Ó Ceanainn wrote: > > Hi everyone, > > > >

Re: [VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-11-29 Thread John Roesler
Thanks, Séamus! I'm +1 (binding). On Mon, 2021-11-29 at 16:14 +, Séamus Ó Ceanainn wrote: > Hi everyone, > > I'd like to start a vote for KIP-799: Align behaviour for producer > callbacks with documented behaviour > <https://cwiki.apache.org/confluence/display/KAFK

[VOTE] KIP-799: Align behaviour for producer callbacks with documented behaviour

2021-11-29 Thread Séamus Ó Ceanainn
Hi everyone, I'd like to start a vote for KIP-799: Align behaviour for producer callbacks with documented behaviour <https://cwiki.apache.org/confluence/display/KAFKA/KIP-799%3A+Align+behaviour+for+producer+callbacks+with+documented+behaviour> . The KIP proposes a breaking