Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-06-16 Thread Jim Hughes
Hi all, As an update, I wanted to say that I updated my PR to include this feedback. Let me know if I should clarify anything on the KIP itself. Cheers, Jim On Thu, Jun 2, 2022 at 12:36 AM Sophie Blee-Goldman wrote: > Hey Jim, thanks for the update. I'm on the same side as Guozhang here, as

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-06-01 Thread Sophie Blee-Goldman
Hey Jim, thanks for the update. I'm on the same side as Guozhang here, as I've expressed during the original discussion I think it would be confusing and possibly harmful to continue *any* kind of processing or action within Streams while it is "paused". In fact I sort of assumed we were including

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-06-01 Thread Guozhang Wang
Hello Jim, I think If our primary goal would be to reduce resource utilization and potentially to stop the streaming pipeline for investigating possible bugs etc, then we should also pause active tasks' restoration as well since that 1) may still use resources, and 2) may load in bad data.

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-06-01 Thread Jim Hughes
Hi all, While reviewing my PR for KIP-834, Bruno noticed a case that we may not have discussed enough.* During the discussion, we decided that standby tasks would be paused. In order to do this, there are changes to the StoreChangelogReader around where it does restorations. Bruno noticed that

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-16 Thread Jim Hughes
Hi all, With 5 binding votes (John, Bruno, Sophie, Matthias, Bill) and 4 non-binding votes (Guozhang, Luke, Leah, Walker), the vote for KIP-834 passes! Thanks all for the great discussion. I have a PR up here: https://github.com/apache/kafka/pull/12161 Thanks in advance for feedback on the

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-13 Thread Walker Carlson
+1 from me (non-binding) Walker On Wed, May 11, 2022 at 12:36 PM Leah Thomas wrote: > Thanks Jim, great discussion. +1 from me (non-binding) > > Cheers, > Leah > > On Wed, May 11, 2022 at 10:14 AM Bill Bejeck wrote: > > > Thanks for the KIP! > > > > +1 (binding) > > > > -Bill > > > > On Wed,

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-11 Thread Leah Thomas
Thanks Jim, great discussion. +1 from me (non-binding) Cheers, Leah On Wed, May 11, 2022 at 10:14 AM Bill Bejeck wrote: > Thanks for the KIP! > > +1 (binding) > > -Bill > > On Wed, May 11, 2022 at 9:36 AM Luke Chen wrote: > > > Hi Jim, > > > > I'm +1. (please add some note in KIP about the

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-11 Thread Bill Bejeck
Thanks for the KIP! +1 (binding) -Bill On Wed, May 11, 2022 at 9:36 AM Luke Chen wrote: > Hi Jim, > > I'm +1. (please add some note in KIP about the stream resetting tool can't > be used in paused state) > Thanks for the KIP! > > Luke > > On Wed, May 11, 2022 at 9:09 AM Guozhang Wang wrote:

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-11 Thread Luke Chen
Hi Jim, I'm +1. (please add some note in KIP about the stream resetting tool can't be used in paused state) Thanks for the KIP! Luke On Wed, May 11, 2022 at 9:09 AM Guozhang Wang wrote: > Thanks Jim. +1 from me. > > On Tue, May 10, 2022 at 4:51 PM Matthias J. Sax wrote: > > > I had one minor

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-10 Thread Guozhang Wang
Thanks Jim. +1 from me. On Tue, May 10, 2022 at 4:51 PM Matthias J. Sax wrote: > I had one minor question on the discuss thread. It's mainly about > clarifying and document the user contract. I am fine either way. > > +1 (binding) > > > -Matthias > > On 5/10/22 12:32 PM, Sophie Blee-Goldman

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-10 Thread Matthias J. Sax
I had one minor question on the discuss thread. It's mainly about clarifying and document the user contract. I am fine either way. +1 (binding) -Matthias On 5/10/22 12:32 PM, Sophie Blee-Goldman wrote: Thanks for the KIP! +1 (binding) On Tue, May 10, 2022, 12:24 PM Bruno Cadonna wrote:

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-10 Thread Sophie Blee-Goldman
Thanks for the KIP! +1 (binding) On Tue, May 10, 2022, 12:24 PM Bruno Cadonna wrote: > Thanks Jim, > > +1 (binding) > > Best, > Bruno > > On 10.05.22 21:19, John Roesler wrote: > > Thanks Jim, > > > > I’m +1 (binding) > > > > -John > > > > On Tue, May 10, 2022, at 14:05, Jim Hughes wrote: > >>

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-10 Thread Bruno Cadonna
Thanks Jim, +1 (binding) Best, Bruno On 10.05.22 21:19, John Roesler wrote: Thanks Jim, I’m +1 (binding) -John On Tue, May 10, 2022, at 14:05, Jim Hughes wrote: Hi all, I'm asking for a vote on KIP-834: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882832 Thanks in

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-10 Thread John Roesler
Thanks Jim, I’m +1 (binding) -John On Tue, May 10, 2022, at 14:05, Jim Hughes wrote: > Hi all, > > I'm asking for a vote on KIP-834: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882832 > > Thanks in advance! > > Jim

[VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-10 Thread Jim Hughes
Hi all, I'm asking for a vote on KIP-834: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882832 Thanks in advance! Jim