[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13894817#comment-13894817 ] Neha Narkhede commented on KAFKA-1171: -- +1. I'm also in favor of proceeding with

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13894916#comment-13894916 ] Joe Stein commented on KAFKA-1171: -- I tried to apply v15 (off a fresh trunk clone) git

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13894922#comment-13894922 ] David Arthur commented on KAFKA-1171: - [~joestein] I usually use git apply when

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13894934#comment-13894934 ] Joe Stein commented on KAFKA-1171: -- yup, great, thanks that worked :) Gradle build

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895019#comment-13895019 ] Jun Rao commented on KAFKA-1171: Just so that we don't carry the big patch for too long. I

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895028#comment-13895028 ] David Arthur commented on KAFKA-1171: - +1 Gradle build for Kafka

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895051#comment-13895051 ] Neha Narkhede commented on KAFKA-1171: -- +1 Gradle build for Kafka

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895058#comment-13895058 ] Joel Koshy commented on KAFKA-1171: --- +1 Gradle build for Kafka --

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895156#comment-13895156 ] Jun Rao commented on KAFKA-1171: Thanks for the review. Patch v15 is now committed. We can

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893576#comment-13893576 ] Neha Narkhede commented on KAFKA-1171: -- Tested patch 14. Here are some review

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893636#comment-13893636 ] Jun Rao commented on KAFKA-1171: These commands no longer exist in the latest patch. The

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13893674#comment-13893674 ] Neha Narkhede commented on KAFKA-1171: -- +1 on the latest patch. Few minor comments -

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892351#comment-13892351 ] Guozhang Wang commented on KAFKA-1171: -- Wondering how to run a single unit test:

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892463#comment-13892463 ] Guozhang Wang commented on KAFKA-1171: -- When I run ./gradlew

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13892908#comment-13892908 ] Jakob Homan commented on KAFKA-1171: There's the test output html, but you can also

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890828#comment-13890828 ] Jay Kreps commented on KAFKA-1171: -- My impression is that people who use Scala have

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891472#comment-13891472 ] David Arthur commented on KAFKA-1171: - Jun, that's fine. I added the subproject name

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891612#comment-13891612 ] Neha Narkhede commented on KAFKA-1171: -- Thanks for the patch, Jun. 1. ./gradlew

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891820#comment-13891820 ] Jun Rao commented on KAFKA-1171: The unit tests issue for scala 2.10.x is caused by

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889696#comment-13889696 ] Jay Kreps commented on KAFKA-1171: -- Shouldn't we default to scala 2.9 or something newer

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889711#comment-13889711 ] Jun Rao commented on KAFKA-1171: Guozhang, That class is included in the patch in

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889719#comment-13889719 ] Guozhang Wang commented on KAFKA-1171: -- No, when I applied the patch these are the

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889860#comment-13889860 ] Jun Rao commented on KAFKA-1171: Please use git apply kafka-1171_v9.patch to try the

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890276#comment-13890276 ] Guozhang Wang commented on KAFKA-1171: -- Tried v9 with all the functionalities, a few

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890278#comment-13890278 ] David Arthur commented on KAFKA-1171: - I've seen some transient test failures as well,

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890403#comment-13890403 ] Jun Rao commented on KAFKA-1171: David, I don't think there is any outstanding issue.

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890404#comment-13890404 ] Jun Rao commented on KAFKA-1171: Jay, Is there any benefit of not defaulting to 2.8.0? I

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13886227#comment-13886227 ] David Arthur commented on KAFKA-1171: - Figured out the POM thing finally. After

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881633#comment-13881633 ] Jun Rao commented on KAFKA-1171: Joe Stein, Do you think you can take a look at maven

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881635#comment-13881635 ] Joe Stein commented on KAFKA-1171: -- yup, will take a look. Gradle build for Kafka

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864627#comment-13864627 ] Christopher Freeman commented on KAFKA-1171: In the patch, the scalatest

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863029#comment-13863029 ] David Arthur commented on KAFKA-1171: - Sorry for being quiet on this for a few weeks -

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13863096#comment-13863096 ] Joe Stein commented on KAFKA-1171: -- with the new patch I was able to get ./gradlew

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13855864#comment-13855864 ] Joe Stein commented on KAFKA-1171: -- Hi David, I applied the latest patch and got stuck

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846289#comment-13846289 ] Joe Stein commented on KAFKA-1171: -- what do we gain moving away from SBT to ant? Ant its

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846314#comment-13846314 ] David Arthur commented on KAFKA-1171: - [~joestein], I think we would gain plenty, but

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846339#comment-13846339 ] Joe Stein commented on KAFKA-1171: -- Even moving to Gradle I will ask the same questions.

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846362#comment-13846362 ] David Arthur commented on KAFKA-1171: - I think having a maintainable build is a big

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846367#comment-13846367 ] Kostya Golikov commented on KAFKA-1171: --- [~mumrah] talking about sbt pros -- it is

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846386#comment-13846386 ] David Arthur commented on KAFKA-1171: - [~omnomnom], looks like the Gradle Scala plugin

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846415#comment-13846415 ] Jay Kreps commented on KAFKA-1171: -- These build discussions tend to blow up due to the

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846529#comment-13846529 ] David Arthur commented on KAFKA-1171: - Yea, I agree we're bike-shedding a bit. Any of

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13846071#comment-13846071 ] David Arthur commented on KAFKA-1171: - I dusted off the Ant build I put together a

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844396#comment-13844396 ] Jun Rao commented on KAFKA-1171: David, Thanks for the patch. Is that all we need to do

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844401#comment-13844401 ] David Arthur commented on KAFKA-1171: - Jun, Gradle does have plugins for IDEs and

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844763#comment-13844763 ] Chris Riccomini commented on KAFKA-1171: For cross-building Scala versions, have a

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844780#comment-13844780 ] Chris Riccomini commented on KAFKA-1171: For the record, a good set of examples on

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844789#comment-13844789 ] David Arthur commented on KAFKA-1171: - [~criccomini] thanks for the pointer. When I

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844808#comment-13844808 ] Chris Riccomini commented on KAFKA-1171: That sounds a lot like a version

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842247#comment-13842247 ] Joe Stein commented on KAFKA-1171: -- Exciting!!! What do think about using a wrapper like

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842250#comment-13842250 ] David Arthur commented on KAFKA-1171: - [~joestein], yea we should definitely use the

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842252#comment-13842252 ] David Arthur commented on KAFKA-1171: - Created reviewboard

[jira] [Commented] (KAFKA-1171) Gradle build for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13842251#comment-13842251 ] David Arthur commented on KAFKA-1171: - Created reviewboard against branch