[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-18 Thread Nicolae Marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066307#comment-14066307 ] Nicolae Marasoiu commented on KAFKA-1535: - awesome, I see you applied the patch

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066439#comment-14066439 ] Jay Kreps commented on KAFKA-1535: -- To date we have not really used pull requests. Apache

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-18 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066538#comment-14066538 ] nicu marasoiu commented on KAFKA-1535: -- Sure do want:) Yes, that was my suggestion as

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-18 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066791#comment-14066791 ] nicu marasoiu commented on KAFKA-1535: -- created KAFKA-1549 with Major priority. I

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-18 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067074#comment-14067074 ] Jay Kreps commented on KAFKA-1535: -- [~nmarasoi] Totally up to you. return all live

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-17 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065424#comment-14065424 ] nicu marasoiu commented on KAFKA-1535: -- updated patch, tests fine, one question

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-17 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065646#comment-14065646 ] Jay Kreps commented on KAFKA-1535: -- Our current model of nodes is that they are

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-16 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064186#comment-14064186 ] Jay Kreps commented on KAFKA-1535: -- Hey Nicu, this looks good to me. Did you do any

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-16 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14064211#comment-14064211 ] nicu marasoiu commented on KAFKA-1535: -- Hi Jay, Great:) For the tests, I just run

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-15 Thread Nicolae Marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061766#comment-14061766 ] Nicolae Marasoiu commented on KAFKA-1535: - Which branch should this be done on?

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-15 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062214#comment-14062214 ] Jay Kreps commented on KAFKA-1535: -- Yeah we do all development on trunk and just cut

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14058949#comment-14058949 ] Jun Rao commented on KAFKA-1535: A solution is to return all live brokers (in metadata

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-11 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059188#comment-14059188 ] nicu marasoiu commented on KAFKA-1535: -- Hi, I am a 11 years java developer and

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059200#comment-14059200 ] Jay Kreps commented on KAFKA-1535: -- Cool, go for it. Just attach a patch to this issue

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-11 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059203#comment-14059203 ] nicu marasoiu commented on KAFKA-1535: -- So what I understand from the issue: the

[jira] [Commented] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-11 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059287#comment-14059287 ] Jay Kreps commented on KAFKA-1535: -- Yes I think that is correct. The current behavior is