[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165278#comment-14165278
]
Jun Rao commented on KAFKA-1644:
Ok, since this a small patch, I double committed to
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165287#comment-14165287
]
Anton Karamanov commented on KAFKA-1644:
That's great news, thanks.
Inherit
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161187#comment-14161187
]
Jun Rao commented on KAFKA-1644:
Perhaps it's better to throw a
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159758#comment-14159758
]
Jun Rao commented on KAFKA-1644:
Alexey,
My only concern of the patch is that it gives
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158114#comment-14158114
]
Alexey Ozeritskiy commented on KAFKA-1644:
--
This patch simplifies writing
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156149#comment-14156149
]
Anton Karamanov commented on KAFKA-1644:
Jun, no {{FetchResponseSend}} still uses
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155678#comment-14155678
]
Guozhang Wang commented on KAFKA-1644:
--
Anton, I think Jun's not saying that there is
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14155903#comment-14155903
]
Jun Rao commented on KAFKA-1644:
Anton,
By letting FetchResponseSend to call
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151423#comment-14151423
]
Anton Karamanov commented on KAFKA-1644:
Does this prevent it from being inherited
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151136#comment-14151136
]
Jun Rao commented on KAFKA-1644:
The reason that FetchResponse is special is that it uses
[
https://issues.apache.org/jira/browse/KAFKA-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143112#comment-14143112
]
Anton Karamanov commented on KAFKA-1644:
Here's a
11 matches
Mail list logo