[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14341089#comment-14341089
]
Neha Narkhede commented on KAFKA-1824:
--
[~gwenshap] Still doesn't apply. Not sure if
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339818#comment-14339818
]
Gwen Shapira commented on KAFKA-1824:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332339#comment-14332339
]
Neha Narkhede commented on KAFKA-1824:
--
[~gwenshap] I'm having trouble applying the
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332054#comment-14332054
]
Gwen Shapira commented on KAFKA-1824:
-
Thats the right RB, [~nehanarkhede].
in
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332011#comment-14332011
]
Neha Narkhede commented on KAFKA-1824:
--
[~gwenshap] Is this the rb you are asking a
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283351#comment-14283351
]
Gwen Shapira commented on KAFKA-1824:
-
Thanks, Jun.
I changed status to Patch
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283216#comment-14283216
]
Jun Rao commented on KAFKA-1824:
Gwen, thanks for point this out. I am reverting
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14283097#comment-14283097
]
Gwen Shapira commented on KAFKA-1824:
-
I noticed that [~junrao] committed KAFKA-1711
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259188#comment-14259188
]
Gwen Shapira commented on KAFKA-1824:
-
[~joestein] 0.8.2 branch is actually ok (i.e.
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256355#comment-14256355
]
Gwen Shapira commented on KAFKA-1824:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256363#comment-14256363
]
Gwen Shapira commented on KAFKA-1824:
-
I added tests, I also did some refactoring to
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14256569#comment-14256569
]
Joe Stein commented on KAFKA-1824:
--
Shouldn't this go into 0.8.2 branch also since it is
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252061#comment-14252061
]
Gwen Shapira commented on KAFKA-1824:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252706#comment-14252706
]
Gwen Shapira commented on KAFKA-1824:
-
Thanks for the quick review [~nehanarkhede]!
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252774#comment-14252774
]
Gwen Shapira commented on KAFKA-1824:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252777#comment-14252777
]
Gwen Shapira commented on KAFKA-1824:
-
My apologies!
Additional round of tests
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252805#comment-14252805
]
Neha Narkhede commented on KAFKA-1824:
--
[~gwenshap] Good catch. I wonder if we should
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14252809#comment-14252809
]
Gwen Shapira commented on KAFKA-1824:
-
Yes, lets do that. Will help us avoid another
18 matches
Mail list logo