[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379900#comment-14379900
]
Ashish K Singh commented on KAFKA-1856:
---
Thanks for helping out [~charmalloc]!
Add
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379331#comment-14379331
]
Joe Stein commented on KAFKA-1856:
--
Testing file
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333528#comment-14333528
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~charmalloc] were you able to get
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333560#comment-14333560
]
Joe Stein commented on KAFKA-1856:
--
[~singhashish] I didn't want to make these changes
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14334046#comment-14334046
]
Ashish Kumar Singh commented on KAFKA-1856:
---
Sounds good [~charmalloc]!
Add
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14332027#comment-14332027
]
Neha Narkhede commented on KAFKA-1856:
--
This is cool. Thanks for working on this,
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14313509#comment-14313509
]
Joe Stein commented on KAFKA-1856:
--
[~singhashish] I created a new jenkins build
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14312596#comment-14312596
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] and [~charmalloc]
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14313546#comment-14313546
]
Ashish Kumar Singh commented on KAFKA-1856:
---
Sounds good [~charmalloc]. Thanks!
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14311140#comment-14311140
]
Gwen Shapira commented on KAFKA-1856:
-
Looks good!
[~joestein] or [~nehanarkhede] -
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14305833#comment-14305833
]
Gwen Shapira commented on KAFKA-1856:
-
Here's what I did and the result:
{code}
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306241#comment-14306241
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] added checkstyle checks
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306237#comment-14306237
]
Ashish Kumar Singh commented on KAFKA-1856:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306164#comment-14306164
]
Ashish Kumar Singh commented on KAFKA-1856:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306178#comment-14306178
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] so the issue was that
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304690#comment-14304690
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] I have tried the
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14303699#comment-14303699
]
Gwen Shapira commented on KAFKA-1856:
-
Once KAFKA-1915 is in, will be nice to include
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285105#comment-14285105
]
Gwen Shapira commented on KAFKA-1856:
-
Non-binding +1 from me :)
Looks good and I'm
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282140#comment-14282140
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] in that case current
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282131#comment-14282131
]
Gwen Shapira commented on KAFKA-1856:
-
Patches where A.B.C branch exist, should be
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282164#comment-14282164
]
Ashish Kumar Singh commented on KAFKA-1856:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282180#comment-14282180
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] I have tested both
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282060#comment-14282060
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~joestein] thanks for the info
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281546#comment-14281546
]
Joe Stein commented on KAFKA-1856:
--
The way we have been developing since from incubation
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281523#comment-14281523
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] If jenkins job
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280890#comment-14280890
]
Gwen Shapira commented on KAFKA-1856:
-
[~singhashish], I see many errors in the tests
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280949#comment-14280949
]
Ashish Kumar Singh commented on KAFKA-1856:
---
[~gwenshap] those errors are due to
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280959#comment-14280959
]
Gwen Shapira commented on KAFKA-1856:
-
Any idea what do other projects do about flaky
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280985#comment-14280985
]
Ashish Kumar Singh commented on KAFKA-1856:
---
I can speak of Apache Hive. The
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280991#comment-14280991
]
Ashish Kumar Singh commented on KAFKA-1856:
---
So, I re-ran it on KAFKA-1664,
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281102#comment-14281102
]
Gwen Shapira commented on KAFKA-1856:
-
It does!
SQOOP's precommit hook contains a
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14281116#comment-14281116
]
Gwen Shapira commented on KAFKA-1856:
-
btw. can you test on a non-trunk version? like
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14277518#comment-14277518
]
Ashish Kumar Singh commented on KAFKA-1856:
---
RB:
[
https://issues.apache.org/jira/browse/KAFKA-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14273923#comment-14273923
]
Neha Narkhede commented on KAFKA-1856:
--
Thanks for filing this [~singhashish]! Look
34 matches
Mail list logo
