[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046499#comment-15046499 ] ASF GitHub Bot commented on KAFKA-1997: --- Github user asfgit closed the pull request at:

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-12-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046296#comment-15046296 ] ASF GitHub Bot commented on KAFKA-1997: --- GitHub user granthenke opened a pull request:

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662838#comment-14662838 ] ASF GitHub Bot commented on KAFKA-1997: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-08-06 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661253#comment-14661253 ] Jiangjie Qin commented on KAFKA-1997: - Oh... I forgot to do it when integrating the

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-08-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661250#comment-14661250 ] ASF GitHub Bot commented on KAFKA-1997: --- GitHub user becketqin opened a pull

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-08-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661161#comment-14661161 ] Jun Rao commented on KAFKA-1997: [~becket_qin], has this been fixed yet? Thanks,

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538900#comment-14538900 ] Jun Rao commented on KAFKA-1997: The reasoning is that there is no good default value to

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-05-11 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538801#comment-14538801 ] Jiangjie Qin commented on KAFKA-1997: - Hey [~junrao], good point. I will do that when

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-05-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538762#comment-14538762 ] Jun Rao commented on KAFKA-1997: A late comment: shouldn't we hardcode the key/value

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-18 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367761#comment-14367761 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-17 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366588#comment-14366588 ] Jiangjie Qin commented on KAFKA-1997: - Created reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366141#comment-14366141 ] Guozhang Wang commented on KAFKA-1997: -- Commit the follow-up patch to trunk.

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-17 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366549#comment-14366549 ] Jiangjie Qin commented on KAFKA-1997: - [~xiaotao183] Yes, that's not right. I'll

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-17 Thread TAO XIAO (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366543#comment-14366543 ] TAO XIAO commented on KAFKA-1997: - [~becket_qin] I think I found a bug in

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-17 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14366052#comment-14366052 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-13 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361156#comment-14361156 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-11 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357714#comment-14357714 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-11 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357993#comment-14357993 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-10 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356079#comment-14356079 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-09 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14354104#comment-14354104 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-05 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14349930#comment-14349930 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-04 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347743#comment-14347743 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-03 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14345879#comment-14345879 ] Jiangjie Qin commented on KAFKA-1997: - Created reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-03 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14346096#comment-14346096 ] Jiangjie Qin commented on KAFKA-1997: - Updated reviewboard

[jira] [Commented] (KAFKA-1997) Refactor Mirror Maker

2015-03-02 Thread Jonathan Creasy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14343488#comment-14343488 ] Jonathan Creasy commented on KAFKA-1997: