[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-08-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734908#comment-13734908 ] Jun Rao commented on KAFKA-347: --- You just need to run bin/kafka-add-partitions.sh. We will

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-08-06 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730616#comment-13730616 ] Cosmin Lehene commented on KAFKA-347: - Is there some operational documentation on how

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-22 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715390#comment-13715390 ] Sriram Subramanian commented on KAFKA-347: -- v2.4 the reason to expose it is for

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715392#comment-13715392 ] Jun Rao commented on KAFKA-347: --- Thanks for patch v2. Looks good overall. Some comments. 20.

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-22 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715469#comment-13715469 ] Sriram Subramanian commented on KAFKA-347: -- 20. Indentation seems fine to me. 21.2

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-22 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715943#comment-13715943 ] Sriram Subramanian commented on KAFKA-347: -- added a script for addpartitions

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716043#comment-13716043 ] Jun Rao commented on KAFKA-347: --- Thanks for the patch. Committed to 0.8. Could you also

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-19 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713864#comment-13713864 ] Neha Narkhede commented on KAFKA-347: - Overall, this looks great and sorry for not

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714259#comment-13714259 ] Joel Koshy commented on KAFKA-347: -- Thanks for patch v2. I'm +1 on this as is, but if you

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-18 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713045#comment-13713045 ] Joel Koshy commented on KAFKA-347: -- Thank you for the patch. Couple of comments, all very

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13707434#comment-13707434 ] Guozhang Wang commented on KAFKA-347: - A few comments: 1. In addPartitions function,

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-01-15 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554062#comment-13554062 ] Jay Kreps commented on KAFKA-347: - Well i think there are really two mappings here: key =