[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2017-04-29 Thread Jeyhun Karimov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989988#comment-15989988 ] Jeyhun Karimov commented on KAFKA-3745: --- [~sree2k] is there an update on issue? > Consider adding

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2017-01-12 Thread Michael Noll (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821054#comment-15821054 ] Michael Noll commented on KAFKA-3745: - I think [~mjsax] meant to say "not a big deal" (rather than

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2017-01-09 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15812244#comment-15812244 ] Matthias J. Sax commented on KAFKA-3745: [~sree2k] thanks for picking this up. Just wanted to

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-10-17 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583262#comment-15583262 ] Matthias J. Sax commented on KAFKA-3745: Yes. AFAIK, we got more request for this. > Consider

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-10-17 Thread Andrew Musselman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583079#comment-15583079 ] Andrew Musselman commented on KAFKA-3745: - Still keeping this open? > Consider adding join key to

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-24 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299045#comment-15299045 ] Guozhang Wang commented on KAFKA-3745: -- Let's leave this ticket open for a while in case we see more

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-24 Thread Greg Fodor (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297745#comment-15297745 ] Greg Fodor commented on KAFKA-3745: --- Actually this seems like a good enough solution, I forgot to

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-23 Thread Greg Fodor (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297733#comment-15297733 ] Greg Fodor commented on KAFKA-3745: --- Yes, the join key needs to be added to the final joined record. I

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297660#comment-15297660 ] Guozhang Wang commented on KAFKA-3745: -- Just wanted to make sure that we are on the same page: even

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-23 Thread Greg Fodor (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297477#comment-15297477 ] Greg Fodor commented on KAFKA-3745: --- Yep, I admit this is definitely not the most common case. But when

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297299#comment-15297299 ] Guozhang Wang commented on KAFKA-3745: -- I may be still getting your motivations wrong, so just for

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-23 Thread Greg Fodor (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297250#comment-15297250 ] Greg Fodor commented on KAFKA-3745: --- sure. we are left joining a KTable against a KStream. The entry in

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296991#comment-15296991 ] Guozhang Wang commented on KAFKA-3745: -- [~gfodor] Actually can you share your join use cases where

[jira] [Commented] (KAFKA-3745) Consider adding join key to ValueJoiner interface

2016-05-23 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296597#comment-15296597 ] Guozhang Wang commented on KAFKA-3745: -- Thanks for reporting this [~gfodor]. > Consider adding join