[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-07-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376692#comment-15376692 ] ASF GitHub Bot commented on KAFKA-3905: --- Github user asfgit closed the pull request at:

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369206#comment-15369206 ] ASF GitHub Bot commented on KAFKA-3905: --- GitHub user rekhajoshm opened a pull request:

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-07-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369204#comment-15369204 ] ASF GitHub Bot commented on KAFKA-3905: --- Github user rekhajoshm closed the pull request at:

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353972#comment-15353972 ] ASF GitHub Bot commented on KAFKA-3905: --- Github user iBuddha closed the pull request at:

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-06-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352551#comment-15352551 ] ASF GitHub Bot commented on KAFKA-3905: --- GitHub user iBuddha opened a pull request:

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-06-27 Thread Xing Huang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352378#comment-15352378 ] Xing Huang commented on KAFKA-3905: --- I think IllegalArgumentException with an error message will be

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-06-27 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352034#comment-15352034 ] Ismael Juma commented on KAFKA-3905: [~wushujames], I agree. > remove null from subscribed topics in

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-06-27 Thread James Cheng (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351906#comment-15351906 ] James Cheng commented on KAFKA-3905: I think it's better to throw an error, instead of silently

[jira] [Commented] (KAFKA-3905) remove null from subscribed topics in KafkaConsumer#subscribe

2016-06-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351785#comment-15351785 ] ASF GitHub Bot commented on KAFKA-3905: --- GitHub user rekhajoshm opened a pull request: