[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989979#comment-15989979
]
ASF GitHub Bot commented on KAFKA-3940:
---
GitHub user mimaison opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843581#comment-15843581
]
ASF GitHub Bot commented on KAFKA-3940:
---
Github user imandhan closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15701279#comment-15701279
]
Ishita Mandhan commented on KAFKA-3940:
---
[~ijuma] I had a quick question about creating a second PR
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446621#comment-15446621
]
ASF GitHub Bot commented on KAFKA-3940:
---
GitHub user imandhan reopened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446620#comment-15446620
]
ASF GitHub Bot commented on KAFKA-3940:
---
Github user imandhan closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437729#comment-15437729
]
ASF GitHub Bot commented on KAFKA-3940:
---
GitHub user imandhan opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437515#comment-15437515
]
ASF GitHub Bot commented on KAFKA-3940:
---
Github user imandhan closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434061#comment-15434061
]
ASF GitHub Bot commented on KAFKA-3940:
---
Github user imandhan closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434062#comment-15434062
]
ASF GitHub Bot commented on KAFKA-3940:
---
GitHub user imandhan reopened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423669#comment-15423669
]
ASF GitHub Bot commented on KAFKA-3940:
---
GitHub user imandhan opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407632#comment-15407632
]
Jim Jagielski commented on KAFKA-3940:
--
Could you send over the patch... either via an attachment or
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15384663#comment-15384663
]
Ishita Mandhan commented on KAFKA-3940:
---
I think we should convert the dir.mkdirs() to
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382927#comment-15382927
]
Jim Jagielski commented on KAFKA-3940:
--
Let me know if I can add myself to the assignee list. Thx
>
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378180#comment-15378180
]
Jim Jagielski commented on KAFKA-3940:
--
In some places we do a dir.mkdirs() and check the return, and
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378157#comment-15378157
]
ASF GitHub Bot commented on KAFKA-3940:
---
Github user jimjag closed the pull request at:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378153#comment-15378153
]
Jim Jagielski commented on KAFKA-3940:
--
I'm fine w/ working w/ Ishita... What I was planning is
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375774#comment-15375774
]
Ismael Juma commented on KAFKA-3940:
Yes, I'd prefer if we handled this across the codebase instead of
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375692#comment-15375692
]
Ishita Mandhan commented on KAFKA-3940:
---
Hi Jim, I got a notification of your PR because I had this
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375225#comment-15375225
]
Jim Jagielski commented on KAFKA-3940:
--
Pull request created
> Log should check the return value of
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375222#comment-15375222
]
ASF GitHub Bot commented on KAFKA-3940:
---
GitHub user jimjag opened a pull request:
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372146#comment-15372146
]
Jun Rao commented on KAFKA-3940:
[~imandhan], we don't need to change dir to Files. We just need to change
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372078#comment-15372078
]
Ishita Mandhan commented on KAFKA-3940:
---
If dir is changed from File to Files here
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368797#comment-15368797
]
Ismael Juma commented on KAFKA-3940:
I think we should just change all usages of File.mkdirs() to
[
https://issues.apache.org/jira/browse/KAFKA-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368315#comment-15368315
]
Jun Rao commented on KAFKA-3940:
Also, instead of using File.mkdirs(), it may be better to use
24 matches
Mail list logo
