[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-12-02 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716971#comment-15716971 ] Guozhang Wang commented on KAFKA-4322: -- I think I agree that some app-specific logic during

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-12-02 Thread Mark Shelton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15716086#comment-15716086 ] Mark Shelton commented on KAFKA-4322: - I do not at all like the idea of using the metrics API in order

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-12-02 Thread Damian Guy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715322#comment-15715322 ] Damian Guy commented on KAFKA-4322: --- My only concern with adding the extra methods is that it breaks

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-12-02 Thread Mark Shelton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15715221#comment-15715221 ] Mark Shelton commented on KAFKA-4322: - >> "We tend not to have such callbacks" The

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-30 Thread Eno Thereska (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708790#comment-15708790 ] Eno Thereska commented on KAFKA-4322: - [~markshelton] We tend not to have such callbacks in streams.

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-22 Thread Mark Shelton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687516#comment-15687516 ] Mark Shelton commented on KAFKA-4322: - The logging is the same for us and logging framework is not the

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687453#comment-15687453 ] Guozhang Wang commented on KAFKA-4322: -- I see. Just for clarification for "own logging" are you just

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-16 Thread Mark Shelton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671564#comment-15671564 ] Mark Shelton commented on KAFKA-4322: - I have a custom store and processor and if no information are

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-16 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15671093#comment-15671093 ] Guozhang Wang commented on KAFKA-4322: -- Thanks [~markshelton], the reason I mentioned a KIP proposal

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-14 Thread Mark Shelton (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665194#comment-15665194 ] Mark Shelton commented on KAFKA-4322: - >> Is there any particular reasons that you want to commit

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15657841#comment-15657841 ] Guozhang Wang commented on KAFKA-4322: -- [~markshelton] Thanks for proposing this ticket. I read the

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654104#comment-15654104 ] ASF GitHub Bot commented on KAFKA-4322: --- GitHub user markcshelton reopened a pull request:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654103#comment-15654103 ] ASF GitHub Bot commented on KAFKA-4322: --- Github user markcshelton closed the pull request at:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651371#comment-15651371 ] ASF GitHub Bot commented on KAFKA-4322: --- GitHub user markcshelton reopened a pull request:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651369#comment-15651369 ] ASF GitHub Bot commented on KAFKA-4322: --- Github user markcshelton closed the pull request at:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651070#comment-15651070 ] ASF GitHub Bot commented on KAFKA-4322: --- GitHub user markcshelton reopened a pull request:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651069#comment-15651069 ] ASF GitHub Bot commented on KAFKA-4322: --- Github user markcshelton closed the pull request at:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647817#comment-15647817 ] ASF GitHub Bot commented on KAFKA-4322: --- GitHub user markcshelton reopened a pull request:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15647816#comment-15647816 ] ASF GitHub Bot commented on KAFKA-4322: --- Github user markcshelton closed the pull request at:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645243#comment-15645243 ] ASF GitHub Bot commented on KAFKA-4322: --- Github user markcshelton closed the pull request at:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15645244#comment-15645244 ] ASF GitHub Bot commented on KAFKA-4322: --- GitHub user markcshelton reopened a pull request:

[jira] [Commented] (KAFKA-4322) StateRestoreCallback begin and end indication

2016-11-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15637668#comment-15637668 ] ASF GitHub Bot commented on KAFKA-4322: --- GitHub user markcshelton opened a pull request: