[jira] [Commented] (KAFKA-4424) Make serializer classes final

2016-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691914#comment-15691914 ] ASF GitHub Bot commented on KAFKA-4424: --- Github user MatthiasBechtold closed the pull request at:

[jira] [Commented] (KAFKA-4424) Make serializer classes final

2016-11-23 Thread Matthias Bechtold (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691904#comment-15691904 ] Matthias Bechtold commented on KAFKA-4424: -- I see, thank you for your time. I did not think

[jira] [Commented] (KAFKA-4424) Make serializer classes final

2016-11-23 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691817#comment-15691817 ] Michael Andre Pearce (IG) commented on KAFKA-4424: -- The link you reference re virtual

[jira] [Commented] (KAFKA-4424) Make serializer classes final

2016-11-23 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691736#comment-15691736 ] Michael Andre Pearce (IG) commented on KAFKA-4424: -- Just reading the link you reference.

[jira] [Commented] (KAFKA-4424) Make serializer classes final

2016-11-23 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691571#comment-15691571 ] Michael Andre Pearce (IG) commented on KAFKA-4424: -- Hi Matthias, When we took your test

[jira] [Commented] (KAFKA-4424) Make serializer classes final

2016-11-23 Thread Matthias Bechtold (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690654#comment-15690654 ] Matthias Bechtold commented on KAFKA-4424: -- Thank you for your feedback, I can totally see your

[jira] [Commented] (KAFKA-4424) Make serializer classes final

2016-11-20 Thread Michael Andre Pearce (IG) (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681447#comment-15681447 ] Michael Andre Pearce (IG) commented on KAFKA-4424: -- Is there a supporting test to prove a