[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227033#comment-14227033
]
Guozhang Wang commented on KAFKA-992:
-
We have seen some scenarios which are not fully
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742296#comment-13742296
]
Guozhang Wang commented on KAFKA-992:
-
As few more thoughts about 113: currently
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742329#comment-13742329
]
Jun Rao commented on KAFKA-992:
---
Thanks for patch v12. A few more comments.
114. If that's
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742356#comment-13742356
]
Guozhang Wang commented on KAFKA-992:
-
Thanks for the comments Jun.
114. Agreed,
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13742837#comment-13742837
]
Jun Rao commented on KAFKA-992:
---
Thanks for patch v14. Committed to 0.8.
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741179#comment-13741179
]
Neha Narkhede commented on KAFKA-992:
-
Overall, v11 is a good refactor. Few minor
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13741587#comment-13741587
]
Guozhang Wang commented on KAFKA-992:
-
Thanks for the comments, Neha, Jun. And sorry
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736988#comment-13736988
]
Jun Rao commented on KAFKA-992:
---
Thanks for patch v8. I think the code can still be made
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737228#comment-13737228
]
Neha Narkhede commented on KAFKA-992:
-
+1 on 80. That's a great suggestion, Jun!
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734903#comment-13734903
]
Jun Rao commented on KAFKA-992:
---
Thanks for the patch. It doesn't seem to apply for me. Do
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734994#comment-13734994
]
Guozhang Wang commented on KAFKA-992:
-
Thanks for the comments Jun. I think the
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734999#comment-13734999
]
Neha Narkhede commented on KAFKA-992:
-
I agree with Guozhang that the logic to ensure
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735437#comment-13735437
]
Neha Narkhede commented on KAFKA-992:
-
+1 on v8. Good catch!
Double
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734114#comment-13734114
]
Neha Narkhede commented on KAFKA-992:
-
Thanks for the follow up patch Guozhang.
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732132#comment-13732132
]
Neha Narkhede commented on KAFKA-992:
-
Thanks for the follow up patch. The changes to
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730916#comment-13730916
]
Jun Rao commented on KAFKA-992:
---
Thinking about this more. The same ZK issue can affect the
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731187#comment-13731187
]
Joel Koshy commented on KAFKA-992:
--
Delayed review - looks good to me, although I still
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731282#comment-13731282
]
Joel Koshy commented on KAFKA-992:
--
ok nm the comment about timestamp. I had forgotten
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731337#comment-13731337
]
Joel Koshy commented on KAFKA-992:
--
and nm for my comments about controller/consumers as
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731352#comment-13731352
]
Neha Narkhede commented on KAFKA-992:
-
We just found a way to reliably reproduce the
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731353#comment-13731353
]
Guozhang Wang commented on KAFKA-992:
-
The zookeeper bug can be reproduced as follows:
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728905#comment-13728905
]
Neha Narkhede commented on KAFKA-992:
-
Thanks for patch v3. Few more review comments -
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13728583#comment-13728583
]
Jay Kreps commented on KAFKA-992:
-
This is good, this can go on trunk, right?
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727438#comment-13727438
]
Swapnil Ghike commented on KAFKA-992:
-
- I think I am not completely clear why
[
https://issues.apache.org/jira/browse/KAFKA-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724789#comment-13724789
]
Guozhang Wang commented on KAFKA-992:
-
We can differentiate this edge case from a
25 matches
Mail list logo