Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Hi Ted, you are right! I fixed it to List. I would prefer the first solution because all the logics will be added on NetworkClient.java, and changing the current AbstractRequest class seems a little unnecessary. Thanks Yishun On Mon, Aug 27, 2018 at 4:57 PM Ted Yu wrote: > > Looking at the code

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Looking at the code for solution #1: } else if (builder.build(version) instanceof List){ wouldn't AbstractRequest be gone due to type erasure ? Which solution do you favor ? Cheers On Mon, Aug 27, 2018 at 4:20 PM

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Sorry for the delay, I have been struggling to come up with a nice solution: I have updated the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-347%3A++Enable+batching+in+FindCoordinatorRequest In summary, to solve the question Guozhang raised: "One tricky question is, how do we know

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Thanks for the clarification. I will address this in my KIP. On Fri, Aug 17, 2018, 12:06 PM Guozhang Wang wrote: > Today we do have logic for auto down-conversion, but it is assuming a > one-to-one mapping. The actual logic is here: > > >

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Today we do have logic for auto down-conversion, but it is assuming a one-to-one mapping. The actual logic is here: https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L775 As you can see, NetworkClient maintains a "apiVersions" map that

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

@Guozhang Wang One thing that I remain confused about (and forgive me if you have explained this to me before), is that if we don't have any transformation helpers (between versions) implemented before, how do we deal with other incompatibility issues when we try to update requests and bump up

Re: 答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

Yishun, some more comments: 1. "All the coordinator ids " + "for this request": it should be "all the requested group ids looking for their coordinators" right? 2. I just thought about this a bit more, regarding "*Compatibility issues between old and new versions need to be considered, we should

答复: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest

+1 (non-binding) 发件人: Yishun Guan 发送时间: 2018年8月17日 8:14 收件人: dev@kafka.apache.org 主题: [VOTE] KIP-347: Enable batching in FindCoordinatorRequest Hi all, I want to start a vote on this KIP: