Re: Call for review: KIP-618

2022-02-23 Thread Chris Egerton
Thanks Mickael! Looking forward to it. On Wed, Feb 23, 2022 at 8:54 AM Mickael Maison wrote: > Hi Chris, > > Thanks for taking the time to split this up. It would indeed be nice > to get this in 3.2. > > I've merged a couple of them already, and I'll make another pass in > the next few days. > >

Re: Call for review: KIP-618

2022-02-23 Thread Mickael Maison
Hi Chris, Thanks for taking the time to split this up. It would indeed be nice to get this in 3.2. I've merged a couple of them already, and I'll make another pass in the next few days. Thanks, Mickael On Sat, Feb 19, 2022 at 12:32 AM Chris Egerton wrote: > > Thanks Luke! Appreciate it. > > On

Re: Call for review: KIP-618

2022-02-18 Thread Chris Egerton
Thanks Luke! Appreciate it. On Thu, Feb 17, 2022 at 10:02 PM Luke Chen wrote: > Hi Chris, > > Thanks for all the PRs (wow, 10K lines of changes). > EOS on source connector is a great feature in Kafka connect! > > I will start to review this PR next week: > Producer fencing API for admin client:

Re: Call for review: KIP-618

2022-02-17 Thread Luke Chen
Hi Chris, Thanks for all the PRs (wow, 10K lines of changes). EOS on source connector is a great feature in Kafka connect! I will start to review this PR next week: Producer fencing API for admin client: https://github.com/apache/kafka/pull/11777 Thank you. Luke On Fri, Feb 18, 2022 at 2:36 AM

Call for review: KIP-618

2022-02-17 Thread Chris Egerton
Hi all, It's been a little over eight months since KIP-618 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-618%3A+Exactly-Once+Support+for+Source+Connectors) was approved, and nearly as long since a feature- and test-complete implementation (initially published in https://github.com/apache