ConsumerTest

2015-02-27 Thread Neha Narkhede
Would anyone object if I commented out the kafka.api.ConsumerTest out until it is fixed? It hangs and is making accepting patches very time-consuming. -- Thanks, Neha

Re: ConsumerTest

2015-02-27 Thread Neha Narkhede
Wow. That was quick :-) Any committers who would also like to give a +1? On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh asi...@cloudera.com wrote: +1 On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira gshap...@cloudera.com wrote: Actually, we will greatly appreciate :) On Fri, Feb 27, 2015

Re: ConsumerTest

2015-02-27 Thread Jiangjie Qin
+1 On 2/27/15, 1:41 PM, Harsha ka...@harsha.io wrote: +1 On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote: Would anyone object if I commented out the kafka.api.ConsumerTest out until it is fixed? It hangs and is making accepting patches very time-consuming. -- Thanks, Neha

Re: ConsumerTest

2015-02-27 Thread Ashish Singh
+1 On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira gshap...@cloudera.com wrote: Actually, we will greatly appreciate :) On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede n...@confluent.io wrote: Would anyone object if I commented out the kafka.api.ConsumerTest out until it is fixed? It hangs

Re: ConsumerTest

2015-02-27 Thread Harsha
+1 On Fri, Feb 27, 2015, at 01:37 PM, Neha Narkhede wrote: Would anyone object if I commented out the kafka.api.ConsumerTest out until it is fixed? It hangs and is making accepting patches very time-consuming. -- Thanks, Neha

Re: ConsumerTest

2015-02-27 Thread Gwen Shapira
Actually, we will greatly appreciate :) On Fri, Feb 27, 2015 at 1:37 PM, Neha Narkhede n...@confluent.io wrote: Would anyone object if I commented out the kafka.api.ConsumerTest out until it is fixed? It hangs and is making accepting patches very time-consuming. -- Thanks, Neha

Re: ConsumerTest

2015-02-27 Thread Joel Koshy
+1 On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote: Wow. That was quick :-) Any committers who would also like to give a +1? On Fri, Feb 27, 2015 at 1:44 PM, Ashish Singh asi...@cloudera.com wrote: +1 On Fri, Feb 27, 2015 at 1:42 PM, Gwen Shapira gshap...@cloudera.com

Re: ConsumerTest

2015-02-27 Thread Neha Narkhede
Thanks for the quick responses. I deleted it for now, since commenting out code is silly given that you can revive the file from version control later. On Fri, Feb 27, 2015 at 2:03 PM, Joel Koshy jjkosh...@gmail.com wrote: +1 On Fri, Feb 27, 2015 at 01:50:07PM -0800, Neha Narkhede wrote:

Re: ConsumerTest

2015-02-27 Thread Guozhang Wang
Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in 1910. On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede n...@confluent.io wrote: Thanks for the quick responses. I deleted it for now, since commenting out code is silly given that you can revive the file from version

Re: ConsumerTest

2015-02-27 Thread Neha Narkhede
Sounds good. Thanks! On Fri, Feb 27, 2015 at 3:01 PM, Guozhang Wang wangg...@gmail.com wrote: Thanks Neha, I will make sure the ConsumerTest gets fixed when I check in 1910. On Fri, Feb 27, 2015 at 2:12 PM, Neha Narkhede n...@confluent.io wrote: Thanks for the quick responses. I deleted