Occasionally a Pull Request will get merged to trunk with an approval from
a community member, but not a committer. We should consider enabling the
GitHub branch protection feature that requires an approval from a committer.

We discussed this some time ago (December 2017)
https://lists.apache.org/thread.html/3ef19c439e978993d1e40f0f30cc0126e79761b7b8910400fb7f18bb%40%3Cdev.kafka.apache.org%3E

While trunk is a protected branch (as far as I know), we have not enabled
the additional review requirement.

Also, since that discussion, GitHub has added Code Owners which allows more
fine grained approval requirements for different areas of code. For a
project as large as Kafka, it might make sense to leverage this as well.

Thoughts?
-- 
David Arthur

Reply via email to