Re: KAFKA-1092 patch for review

2013-10-30 Thread Roger Hoover
Jun, I've fixed the two things you mentioned. All the tests now pass. Cheers, Roger On Wed, Oct 30, 2013 at 10:53 AM, Roger Hoover wrote: > Thanks! I'll work on incorporating your feedback. > > > On Wed, Oct 30, 2013 at 10:34 AM, Jun Rao wrote: > >> Reviewed. >> >> Thanks, >> >> Jun >> >> >

Re: KAFKA-1092 patch for review

2013-10-30 Thread Roger Hoover
Thanks! I'll work on incorporating your feedback. On Wed, Oct 30, 2013 at 10:34 AM, Jun Rao wrote: > Reviewed. > > Thanks, > > Jun > > > On Wed, Oct 30, 2013 at 9:45 AM, Roger Hoover >wrote: > > > Hi dev list, > > > > As suggested on the website, this is a friendly nag. I submitted a patch >

Re: KAFKA-1092 patch for review

2013-10-30 Thread Jun Rao
Reviewed. Thanks, Jun On Wed, Oct 30, 2013 at 9:45 AM, Roger Hoover wrote: > Hi dev list, > > As suggested on the website, this is a friendly nag. I submitted a patch > for a config change. Can someone please take a look? > > Here's the message I posted to the users list: > > OK. I've submi

KAFKA-1092 patch for review

2013-10-30 Thread Roger Hoover
Hi dev list, As suggested on the website, this is a friendly nag. I submitted a patch for a config change. Can someone please take a look? Here's the message I posted to the users list: OK. I've submitted a patch along with unit tests. This change is backward compatible with two new optional