Re: [VOTE] KIP-202

2017-09-26 Thread Guozhang Wang
ma wrote: > > > > > Thanks for the KIP, +1 (binding). > > > > > > On 19 Sep 2017 12:27 am, "Richard Yu" > > wrote: > > > > > > > Hello, I would like to start a VOTE thread on KIP-202. > > > > > > > > Thanks. > > > > > > > > > > > > > > > -- > > -- Guozhang > > > -- -- Guozhang

Re: [VOTE] KIP-202

2017-09-25 Thread Richard Yu
; > Thanks for the KIP, +1 (binding). > > > > On 19 Sep 2017 12:27 am, "Richard Yu" > wrote: > > > > > Hello, I would like to start a VOTE thread on KIP-202. > > > > > > Thanks. > > > > > > > > > -- > -- Guozhang >

Re: [VOTE] KIP-202

2017-09-25 Thread Guozhang Wang
If no on else has opinions or votes on this thread, Richard could you close the voting phase then? On Sat, Sep 23, 2017 at 4:11 PM, Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > On 19 Sep 2017 12:27 am, "Richard Yu" wrote: > > > Hello, I would like t

Re: [VOTE] KIP-202

2017-09-23 Thread Ismael Juma
Thanks for the KIP, +1 (binding). On 19 Sep 2017 12:27 am, "Richard Yu" wrote: > Hello, I would like to start a VOTE thread on KIP-202. > > Thanks. >

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-19 Thread Richard Yu
gt;> streams, a warning will be printed (or logged), but this should not > > >>> hinder > > >>>> ability to read the log. > > >>>> There is a missing unchecked warning suppression for the old method. > > >>>> However, it is not high priority due

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-19 Thread Guozhang Wang
>>>> streams, a warning will be printed (or logged), but this should not > >>> hinder > >>>> ability to read the log. > >>>> There is a missing unchecked warning suppression for the old method. > >>>> However, it is not high prio

Re: [VOTE] KIP-202

2017-09-19 Thread Richard Yu
t; If we can make it in 1.0.0, I think we can just remove the merge() in > >>>> StreamsBuilder as it will only be introduced in 1.0.0; if we will add > >> it > >>> in > >>>> 1.1.0, then we indeed need to deprecate it. > >>>> > >>>>

Re: [VOTE] KIP-202

2017-09-19 Thread Matthias J. Sax
>>> If we can make it in 1.0.0, I think we can just remove the merge() in >>>> StreamsBuilder as it will only be introduced in 1.0.0; if we will add >> it >>> in >>>> 1.1.0, then we indeed need to deprecate it. >>>> >>>> >

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-19 Thread Matthias J. Sax
o deprecation of the old merge() >>>> method. >>>> >>>> >>>> On Sun, Sep 17, 2017 at 9:37 AM, Richard Yu < >> yohan.richard...@gmail.com> >>>> wrote: >>>> >>>>> With regards to Xavier's comment, this pr

Re: [VOTE] KIP-202

2017-09-19 Thread Richard Yu
to deprecate it. > > > > > > > > > Guozhang > > > > > > > > > On Tue, Sep 19, 2017 at 7:29 AM, Richard Yu < > yohan.richard...@gmail.com> > > > wrote: > > > > > > > KIP-202 Move merge() from StreamsBuilder to KStream

Re: [VOTE] KIP-202

2017-09-19 Thread Damian Guy
as it will only be introduced in 1.0.0; if we will add it > in > > 1.1.0, then we indeed need to deprecate it. > > > > > > Guozhang > > > > > > On Tue, Sep 19, 2017 at 7:29 AM, Richard Yu > > wrote: > > > > > KIP-202 Move merge()

Re: [VOTE] KIP-202

2017-09-19 Thread Bill Bejeck
to deprecate it. > > > Guozhang > > > On Tue, Sep 19, 2017 at 7:29 AM, Richard Yu > wrote: > > > KIP-202 Move merge() from StreamsBuilder to KStream. > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 202+Move+merge%28%29+from+StreamsBuilder+t

Re: [VOTE] KIP-202

2017-09-19 Thread Guozhang Wang
Thanks for the KIP, +1. If we can make it in 1.0.0, I think we can just remove the merge() in StreamsBuilder as it will only be introduced in 1.0.0; if we will add it in 1.1.0, then we indeed need to deprecate it. Guozhang On Tue, Sep 19, 2017 at 7:29 AM, Richard Yu wrote: > KIP-202 M

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-19 Thread Damian Guy
> > wrote: > > > > > >> With regards to Xavier's comment, this practice I do no think applies > to > > >> this PR. There is not much potential here for warnings to be thrown. > > Note > > >> that in StreamsBuilder's merge, their is no > > @S

Re: [VOTE] KIP-202

2017-09-18 Thread Richard Yu
KIP-202 Move merge() from StreamsBuilder to KStream. https://cwiki.apache.org/confluence/display/KAFKA/KIP-202+Move+merge%28%29+from+StreamsBuilder+to+KStream This is the link for the VOTE. On Mon, Sep 18, 2017 at 4:27 PM, Richard Yu wrote: > Hello, I would like to start a VOTE thread on

[VOTE] KIP-202

2017-09-18 Thread Richard Yu
Hello, I would like to start a VOTE thread on KIP-202. Thanks.

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-18 Thread Richard Yu
un, Sep 17, 2017 at 9:37 AM, Richard Yu > > wrote: > > > >> With regards to Xavier's comment, this practice I do no think applies to > >> this PR. There is not much potential here for warnings to be thrown. > Note > >> that in StreamsBuilder's merge,

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-17 Thread Matthias J. Sax
nings is sparse, if not nonexistent. >> >> >> On Sun, Sep 17, 2017 at 9:10 AM, Richard Yu >> wrote: >> >>> KIP-202 has been changed according to the conditions of your suggestion. >>> >>> On Sun, Sep 17, 2017 at 8:51 AM, Richard Yu >>> w

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-17 Thread Richard Yu
> @SuppressWarnings("unchecked")--indicating > that warnings is sparse, if not nonexistent. > > > On Sun, Sep 17, 2017 at 9:10 AM, Richard Yu > wrote: > >> KIP-202 has been changed according to the conditions of your suggestion. >> >> On Sun, Sep 17, 2017 a

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-17 Thread Richard Yu
nt. On Sun, Sep 17, 2017 at 9:10 AM, Richard Yu wrote: > KIP-202 has been changed according to the conditions of your suggestion. > > On Sun, Sep 17, 2017 at 8:51 AM, Richard Yu > wrote: > >> I added StreamsBuilder under the assumption that InternalStreamBuilder >> wou

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-17 Thread Richard Yu
KIP-202 has been changed according to the conditions of your suggestion. On Sun, Sep 17, 2017 at 8:51 AM, Richard Yu wrote: > I added StreamsBuilder under the assumption that InternalStreamBuilder > would be required to merge > two streams. However, if that is not the case, then I wo

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-17 Thread Richard Yu
> -Matthias > > On 9/16/17 9:36 PM, Richard Yu wrote: > > Hi, > > Please take a look at: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 202+Move+merge%28%29+from+StreamsBuilder+to+KStream > > > > Thanks > > > >

Re: [Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-17 Thread Matthias J. Sax
e a look at: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 202+Move+merge%28%29+from+StreamsBuilder+to+KStream > > Thanks > signature.asc Description: OpenPGP digital signature

[Discuss] KIP-202 Move merge() from StreamsBuilder to KStream

2017-09-16 Thread Richard Yu
Hi, Please take a look at: https://cwiki.apache.org/confluence/display/KAFKA/KIP- 202+Move+merge%28%29+from+StreamsBuilder+to+KStream Thanks

KIP-202

2017-09-16 Thread Richard Yu
Hi, Please take a look at: https://cwiki.apache.org/confluence/display/KAFKA/KIP-202+Move+merge%28%29+from+StreamsBuilder+to+KStream Thanks