Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

Hi everybody, I just want to ping this discussion. Any thoughts? - Yuriy On Fri, Jun 5, 2020 at 10:22 AM Yuriy Badalyantc wrote: > Hi Matthias, > > I think you misunderstood my diagram. I wanted to show the next > relationships: > - Serde is KeySerde and ValueSerde > - KeySerde is

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

Hi Matthias, I think you misunderstood my diagram. I wanted to show the next relationships: - Serde is KeySerde and ValueSerde - KeySerde is KeySerializer and KeyDeserializer - ValueSerde is ValueSerializer and ValueDeserializer So, `Serde` is is most "powerfull" class. It could do anything.

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

As you say "hierarchy" I read this really as "class hierarchy". For this case, I think that we need to do it differently. I agree to this part: KeySerde extends Serde ValueSerde extends Serde However, KeySerializer extends KeySerde (etc) does not make sense IMHO, because a

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

Hi. I'm the author of the KIP-616. I got acquainted with the KIP-513 and I think overall it's a good idea. But I think workaround only on the scala side is not enough. We could consider moving a bit further and change serde hierarchy on the java side to something like this: KeySerializer-↘

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

Hi Mykhailo, Wow, I really dropped the ball here. I have just looked over your KIP again, and now I see how you don’t need to change every dsl method, only Consumed, Materialized, etc. I think this would be a good addition. Yuriy has just proposed KIP-616 to fix some other problems with the

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

Hi, John! Sorry for the late reply. I am not really familiar with this mail list discussions, so I have not seen your mails. Regarding your question: > I guess what I'm struggling with is why you actually want to have different key and serdes for the same type I think good example will

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

Hi Mykhailo, I've been mulling over your KIP today. I think that what you're proposing makes sense. I'm having a little trouble wrapping my head around the exact problem with the current API, though... It sounds like you're saying that you want to have different key and value serdes for the same

Re: [DISCUSS] KIP-513: Distinguish between Key and Value serdes in scala wrapper library for kafka streams

Hey Mykhailo, I just wanted to let you know that I'm looking at your proposal, but it'll take me a little while to re-activate the Scala part of my brain. For everyone's benefit, here's the link to the KIP: