Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-25 Thread Jun Rao
Hi, Ron, Thanks for the explanation. That makes sense. So, this is not an issue. Jun On Tue, Sep 25, 2018 at 11:53 AM, Ron Dagostino wrote: > Hi Jun. I see now what you were getting at. This is actually not a > problem because the authentication code path does not leverage the >

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-25 Thread Ron Dagostino
Hi Jun. I see now what you were getting at. This is actually not a problem because the authentication code path does not leverage the NetworkClient instance -- it reads to/writes from the TransportLayer directly and sets its own API version numbers manually. Re-authentication leverages the same

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-25 Thread Jun Rao
Hi, Ron, 103. I was referring to the following code in ReplicaFetcherBlockingSend. As you can see, when instantiating NetworkClient, we disable the discoverBrokerVersions flag. So the network client won't know the version that the destination broker supports. Instead, the source broker is

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-24 Thread Ron Dagostino
Hi everyone. This concludes the vote for KIP 368. The vote passes with three binding + 1 votes, from Rajini, Harsha, and Jun, and seven non-binding +1 votes, from Mike, Konstantin, Boerge, Edoardo, Stanislav, Mickael, and myself. I have marked the KIP as "Accepted". The pull request, available

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-24 Thread Ron Dagostino
Thanks, Jun. <<<100 I added this line to the KIP to clarify the SSL issue: "This KIP has no impact on non-SASL connections (e.g. connections that use the PLAINTEXT or SSL security protocols) – no such connection will be re-authenticated, and no such connection will be closed." <<<101 Your

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-24 Thread Jun Rao
Hi, Ron, Thanks for the KIP. Looks good to me overall. So, +1 assuming the following minor comments will be addressed. 100. connections.max.reauth.ms: A client can authenticate with the broker using SSL. This config has no impact on such connections. It would be useful to make it clear in the

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-24 Thread Ron Dagostino
Still looking for a final +1 binding vote to go with the 9 votes so far (2 binding, 7 non-binding). Ron > On Sep 24, 2018, at 3:53 PM, Ron Dagostino wrote: > > **Please vote** . It's getting late in the day and this KIP still requires 1 > more binding up-vote to be considered for the 2.1.0

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-24 Thread Ron Dagostino
**Please vote** . It's getting late in the day and this KIP still requires 1 more binding up-vote to be considered for the 2.1.0 release. The current vote is 2 binding +1 votes (Rajini and Harsha) and 7 non-binding +1 votes (myself, Mike, Konstantin, Boerge, Edoardo, Stanislav, and Mickael).

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-24 Thread Ron Dagostino
Hi Everyone. This KIP still requires 1 more binding up-vote to be considered for the 2.1.0 release. **Please vote before today's end-of-day deadline.** The current vote is 2 binding +1 votes (Rajini and Harsha) and 7 non-binding +1 votes (myself, Mike, Konstantin, Boerge, Edoardo, Stanislav,

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-21 Thread Mickael Maison
+1 (non-binding) Thanks for the KIP, this is a very nice feature. On Fri, Sep 21, 2018 at 4:56 PM Stanislav Kozlovski wrote: > > Thanks for the KIP, Ron! > +1 (non-binding) > > On Fri, Sep 21, 2018 at 5:26 PM Ron Dagostino wrote: > > > Hi Everyone. This KIP requires 1 more binding up-vote to be

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-21 Thread Stanislav Kozlovski
Thanks for the KIP, Ron! +1 (non-binding) On Fri, Sep 21, 2018 at 5:26 PM Ron Dagostino wrote: > Hi Everyone. This KIP requires 1 more binding up-vote to be considered for > the 2.1.0 release; please vote before the Monday deadline. > > The current vote is 2 binding +1 votes (Rajini and

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-21 Thread Ron Dagostino
Hi Everyone. This KIP requires 1 more binding up-vote to be considered for the 2.1.0 release; please vote before the Monday deadline. The current vote is 2 binding +1 votes (Rajini and Harsha) and 5 non-binding +1 votes (myself, Mike, Konstantin, Boerge, and Edoardo). Ron On Wed, Sep 19, 2018

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-19 Thread Harsha
KIP looks good. +1 (binding) Thanks, Harsha On Wed, Sep 19, 2018, at 7:44 AM, Rajini Sivaram wrote: > Hi Ron, > > Thanks for the KIP! > > +1 (binding) > > On Tue, Sep 18, 2018 at 6:24 PM, Konstantin Chukhlomin > wrote: > > > +1 (non binding) > > > > > On Sep 18, 2018, at 1:18 PM,

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-19 Thread Rajini Sivaram
Hi Ron, Thanks for the KIP! +1 (binding) On Tue, Sep 18, 2018 at 6:24 PM, Konstantin Chukhlomin wrote: > +1 (non binding) > > > On Sep 18, 2018, at 1:18 PM, michael.kamin...@nytimes.com wrote: > > > > > > > > On 2018/09/18 14:59:09, Ron Dagostino wrote: > >> Hi everyone. I would like to

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-18 Thread Konstantin Chukhlomin
+1 (non binding) > On Sep 18, 2018, at 1:18 PM, michael.kamin...@nytimes.com wrote: > > > > On 2018/09/18 14:59:09, Ron Dagostino wrote: >> Hi everyone. I would like to start the vote for KIP-368: >>

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-18 Thread michael . kaminski
On 2018/09/18 14:59:09, Ron Dagostino wrote: > Hi everyone. I would like to start the vote for KIP-368: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-368%3A+Allow+SASL+Connections+to+Periodically+Re-Authenticate > > This KIP proposes adding the ability for SASL clients (and

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-18 Thread michael . kaminski
On 2018/09/18 14:59:09, Ron Dagostino wrote: > Hi everyone. I would like to start the vote for KIP-368: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-368%3A+Allow+SASL+Connections+to+Periodically+Re-Authenticate > > This KIP proposes adding the ability for SASL clients (and

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-18 Thread Boerge Svingen
t; IBM Message Hub > > IBM UK Ltd, Hursley Park, SO21 2JN > > > > From: Ron Dagostino > To: dev@kafka.apache.org > Date: 18/09/2018 16:09 > Subject: [VOTE] KIP 368: Allow SASL Connections to Periodically > Re-Authenticate > > > > Hi every

Re: [VOTE] KIP 368: Allow SASL Connections to Periodically Re-Authenticate

2018-09-18 Thread Edoardo Comar
+1 (non binding) Thanks Ron & Rajini ! -- Edoardo Comar IBM Message Hub IBM UK Ltd, Hursley Park, SO21 2JN From: Ron Dagostino To: dev@kafka.apache.org Date: 18/09/2018 16:09 Subject: [VOTE] KIP 368: Allow SASL Connect