Re: Review Request 14496: Patch for KAFKA-1073

2013-10-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/#review26704 --- Thanks for the patch. I also think deprecating this and adding a --v

Re: Review Request 14496: Patch for KAFKA-1073

2013-10-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/#review26703 --- Ship it! Agree with Swapnil. - Guozhang Wang On Oct. 4, 2013, 9:

Re: Review Request 14496: Patch for KAFKA-1073

2013-10-04 Thread Swapnil Ghike
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14496/#review26701 --- Ship it! Do you think incorporating this functionality in the Reass