---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review44964
---
If a consumer fails to establish a connection to zookeeper, how is
On May 19, 2014, 5:30 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java,
lines 70-71
https://reviews.apache.org/r/19731/diff/11/?file=583622#file583622line70
Instead of introducing ConsumerRecords, I'd prefer just returning
MapString,
On May 19, 2014, 6:22 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java,
lines 99-119
https://reviews.apache.org/r/19731/diff/11/?file=583622#file583622line99
Should we discuss about code conventions of using ellipse (i.e. an
On May 19, 2014, 6:51 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java,
lines 27-28
https://reviews.apache.org/r/19731/diff/11/?file=583623#file583623line27
Have we added the config for selecting the strategy for assigning
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated May 20, 2014, 11:34 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review43558
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review43365
---
On May 19, 2014, 5:30 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java,
lines 70-71
https://reviews.apache.org/r/19731/diff/11/?file=583622#file583622line70
Instead of introducing ConsumerRecords, I'd prefer just returning
MapString,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review43385
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review43395
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review42405
---
The javadoc for KafkaConsumer is missing in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated May 10, 2014, 12:18 a.m.)
Review request for kafka.
Bugs:
On May 7, 2014, 4:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java,
lines 37-38
https://reviews.apache.org/r/19731/diff/7-8/?file=555628#file555628line37
partitionId can probably be just partition to be consistent with what's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review42787
---
On May 7, 2014, 4:50 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java,
lines 87-88
https://reviews.apache.org/r/19731/diff/9/?file=574802#file574802line87
The Future thing doesn't work well in this case. This is because the
caller
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review41974
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated May 5, 2014, 6:35 p.m.)
Review request for kafka.
Bugs: KAFKA-1328
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated May 5, 2014, 6:35 p.m.)
Review request for kafka.
Bugs: KAFKA-1328
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review40856
---
1. I am not sure about the use of ellipsis. This may make passing a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review40262
---
Some general comments:
1. Do we need to take parameters for
On April 7, 2014, 6:03 p.m., Guozhang Wang wrote:
clients/src/main/java/kafka/clients/consumer/ConsumerRecord.java, line 22
https://reviews.apache.org/r/19731/diff/1/?file=538463#file538463line22
Suggest add the following functions:
compressionType()
Neha Narkhede
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated April 13, 2014, 1:30 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated April 13, 2014, 2:12 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated April 11, 2014, 5:54 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated April 11, 2014, 6:16 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/
---
(Updated April 11, 2014, 1:30 a.m.)
Review request for kafka.
Bugs:
On April 7, 2014, 6:13 p.m., Timothy Chen wrote:
clients/src/main/java/kafka/clients/consumer/Consumer.java, line 61
https://reviews.apache.org/r/19731/diff/1/?file=538460#file538460line61
I wonder if it's worth adding more comments about the poll behavior
here, about what
On April 7, 2014, 6:03 p.m., Guozhang Wang wrote:
clients/src/main/java/kafka/clients/consumer/Consumer.java, line 41
https://reviews.apache.org/r/19731/diff/1/?file=538460#file538460line41
Just wanted to confirm again that we agree to expose TopicPartition to
users? Though it is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review39700
---
clients/src/main/java/kafka/clients/consumer/Consumer.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19731/#review39694
---
clients/src/main/java/kafka/clients/consumer/Consumer.java
30 matches
Mail list logo
