---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23705/
---
(Updated July 23, 2014, 2:55 p.m.)
Review request for kafka.
Bugs:
On July 21, 2014, 6:16 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165
https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165
Would key also be null possibly?
Manikumar Reddy O wrote:
This line is surrounded by
On July 21, 2014, 6:16 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165
https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165
Would key also be null possibly?
Manikumar Reddy O wrote:
This line is surrounded by
On July 21, 2014, 6:16 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165
https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165
Would key also be null possibly?
This line is surrounded by if(msg.hasKey) check.
msg.hasKey
On July 21, 2014, 6:16 p.m., Guozhang Wang wrote:
core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165
https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165
Would key also be null possibly?
Manikumar Reddy O wrote:
This line is surrounded by
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23705/#review48440
---
Looks good. Just one minor comment below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23705/
---
(Updated July 21, 2014, 3:16 p.m.)
Review request for kafka.
Summary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23705/#review48265
---
core/src/main/scala/kafka/tools/DumpLogSegments.scala