Re: SessionKeySchema#segmentsToSearch()

2017-11-20 Thread Damian Guy
w.r.t `SessionKeySchema` MAX_VALUE is correct. This is because we use the end time (rather than the start time) of the session to define which segment the session is in. So it could be in any segment starting from `from` time. On Sun, 19 Nov 2017 at 20:27 Ted Yu wrote: > For `getMinSegmentGreate

Re: SessionKeySchema#segmentsToSearch()

2017-11-19 Thread Ted Yu
For `getMinSegmentGreaterThanEqualToTimestamp` , the email was indeed meant for #4162. Pardon. On Sun, Nov 19, 2017 at 11:55 AM, Guozhang Wang wrote: > For `SessionKeySchema#segmentsToSearch`: for session store, multiple > sessions may merge together when receiving late arrived records. When I

Re: SessionKeySchema#segmentsToSearch()

2017-11-19 Thread Guozhang Wang
For `SessionKeySchema#segmentsToSearch`: for session store, multiple sessions may merge together when receiving late arrived records. When I looked at the code, it seems that we have merged the sessions during aggregations to effectively move the sessions between segments. So I'm not 100% certain w

Re: SessionKeySchema#segmentsToSearch()

2017-11-18 Thread Ted Yu
This code: final Segment minSegment = segments .getMinSegmentGreaterThanEqualToTimestamp(timeFrom); final Segment maxSegment = segments .getMaxSegmentLessThanEqualToTimestamp(timeTo); Can be replaced with: final List searchSpace = keySchema.segmentsToSearch( segments, fr