Re: Review Request 14554: Move AddPartitions into TopicCommand in trunk

2013-10-09 Thread Sriram Subramanian
> On Oct. 9, 2013, 5:31 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala, line 122 > > > > > > Why need to increment the added # partitions by 1 here? The addPartitions input

Re: Review Request 14554: Move AddPartitions into TopicCommand in trunk

2013-10-09 Thread Sriram Subramanian
> On Oct. 9, 2013, 5:23 p.m., Jun Rao wrote: > > Got the following error when running the tool. > > > > bin/kafka-topics.sh --zookeeper localhost:2181 --alter --partitions 3 > > --topic test > > partitions can only be added when topic has no key > > Exception in thread "main" java.lang.NullPoin

Re: Review Request 14554: Move AddPartitions into TopicCommand in trunk

2013-10-09 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14554/#review26823 --- core/src/main/scala/kafka/admin/TopicCommand.scala

Re: Review Request 14554: Move AddPartitions into TopicCommand in trunk

2013-10-09 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14554/#review26821 --- Got the following error when running the tool. bin/kafka-topics.sh

Review Request 14554: Move AddPartitions into TopicCommand in trunk

2013-10-08 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14554/ --- Review request for kafka. Bugs: KAFKA-1052 https://issues.apache.org/jira/b