Re: Review Request 16335: Patch for KAFKA-1187

2013-12-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16335/#review30765 --- Ship it! Ship It! - Jun Rao On Dec. 18, 2013, 12:29 a.m., Neha N

Re: Review Request 16335: Patch for KAFKA-1187

2013-12-18 Thread Neha Narkhede
> On Dec. 18, 2013, 1:19 a.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/controller/ControllerChannelManager.scala, line > > 116 > > > > > > If connectToBroker timed out here, the thread will die here. So sha

Re: Review Request 16335: Patch for KAFKA-1187

2013-12-17 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16335/#review30592 --- core/src/main/scala/kafka/controller/ControllerChannelManager.scala

Review Request 16335: Patch for KAFKA-1187

2013-12-17 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16335/ --- Review request for kafka. Bugs: KAFKA-1187 https://issues.apache.org/jira/b