Re: Review Request 19510: Patch for KAFKA-1318-v2

2014-04-01 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/#review39171 --- Ship it! Ship It! - Neha Narkhede On March 31, 2014, 5:32 p.m.,

Re: Review Request 19510: Patch for KAFKA-1318-v2

2014-03-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/#review39101 --- Ship it! Ship It! - Guozhang Wang On March 31, 2014, 5:32 p.m.,

Re: Review Request 19510: Patch for KAFKA-1318-v2

2014-03-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/#review39070 --- Ah found it! Was searching for popen earlier. - Timothy Chen On M

Re: Review Request 19510: Patch for KAFKA-1318-v2

2014-03-31 Thread Jun Rao
> On March 31, 2014, 5:36 p.m., Timothy Chen wrote: > > Not sure if I'm missing something here, but I don't see any > > Popen.communicate changes in this rb? It is there. Search for subproc.communicate() in system_test/utils/kafka_system_test_utils.py. - Jun ---

Re: Review Request 19510: Patch for KAFKA-1318-v2

2014-03-31 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/#review39068 --- Not sure if I'm missing something here, but I don't see any Popen.co

Re: Review Request 19510: Patch for KAFKA-1318-v2

2014-03-31 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/ --- (Updated March 31, 2014, 5:32 p.m.) Review request for kafka. Summary (update

Re: Review Request 19510: Patch for KAFKA-1318

2014-03-21 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/#review38119 --- Ship it! Ship It! - Neha Narkhede On March 21, 2014, 1:01 a.m.,

Re: Review Request 19510: Patch for KAFKA-1318

2014-03-20 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/#review38028 --- Ship it! system_test/utils/kafka_system_test_utils.py

Review Request 19510: Patch for KAFKA-1318

2014-03-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19510/ --- Review request for kafka. Bugs: KAFKA-1318 https://issues.apache.org/jira/b