Re: Review Request 20240: Follow-up KAFKA-1352: Standardize stack trace printing in logs

2014-04-24 Thread Guozhang Wang
> On April 24, 2014, 6:53 p.m., Joel Koshy wrote: > > Here are my initial thoughts on the conventions (and for this kind of RB - > > i.e., which affects our coding conventions it would be great to have as many > > opinions as possible). > > > > - Single line log seems reasonable. The exception f

Re: Review Request 20240: Follow-up KAFKA-1352: Standardize stack trace printing in logs

2014-04-24 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20240/#review41347 --- Here are my initial thoughts on the conventions (and for this kind o

Re: Review Request 20240: Follow-up KAFKA-1352: Standardize stack trace printing in logs

2014-04-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20240/ --- (Updated April 11, 2014, 12:05 a.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 20240: Follow-up KAFKA-1352: Standardize stack trace printing in logs

2014-04-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20240/ --- (Updated April 10, 2014, 11:46 p.m.) Review request for kafka. Bugs: KAFKA-13

Review Request 20240: Follow-up KAFKA-1352: Standardize stack trace printing in logs

2014-04-10 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20240/ --- Review request for kafka. Bugs: KAFKA-1352 https://issues.apache.org/jira/b